New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ordered list to unordered list in project challenges #8867
Comments
I think this is a lot better! |
can i try this or there is more discussion on this ?? |
@Sanskar-Modi let's wait for @hallaathrad opinion! |
Hmm haven't checked on all cases, but at least right now it makes a lot of sense to me. I'd say we take it, and then if any specific challenge requires an ordered list, we go an fix it on a case by case. PS: While we're at it, can we try to figure out whether we actually need checkboxes? Most of the time they've seemed pointless to me in a practical sense. |
Perfect, now a matter of removing the space on the left of the list, and we should be golden. |
Yup, lets save some more real estate! |
@hallaathrad @raisedadead, yeah let's do it! |
@Sanskar-Modi, feel free to tackle this now! We have decided to remove the checkboxes and numbers. Please, check our Guidelines for Contributing and if you need any assistance reach out to the Contributors Chat room. |
Looks like this has been fixed. Reopen if I'm mistaken. |
Challenge Name
Any of the project challenge pages (e.g https://www.freecodecamp.com/challenges/show-the-local-weather)
Issue Description
Currently, the project challenges have an ordered list, listing the requirements and instructions for the challenge. However, I think there are too many "lists" as there is a bulleted list and the numerical list.
Firstly, I remember reading someone making an issue or comment on how the rule numbers usually make a weird contrast with its list number, like so where
Rule #1
is listed as#2
in the list:Secondly, there appears to be a redundancy in "lists," where you have the check boxes but also the numbered list items. Each item is already separated by spaces so I don't think you really need the numbers.
Numbers in a list, in my opinion, should have some meaning to it like needing to know there are 3 or 4 requirements for something. But in this case, the numbers don't really tell you much except there are 10 or so lines to read, which knowing the number is inconsequential to solving the challenge.
Proposed Fix
Change the ordered list to an unordered one. To make these changes, I think all we'd need to do is change this line from
ol
toul
(correct me if I'm wrong). Overall, I think these changes will give a cleaner look to the challenges.Screenshot
Currently:
Proposed Change:
cc/ @hallaathrad
The text was updated successfully, but these errors were encountered: