Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ordered list to unordered list in project challenges #8867

Closed
erictleung opened this issue May 31, 2016 · 10 comments
Closed

Change ordered list to unordered list in project challenges #8867

erictleung opened this issue May 31, 2016 · 10 comments
Labels
help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface

Comments

@erictleung
Copy link
Member

erictleung commented May 31, 2016

Challenge Name

Any of the project challenge pages (e.g https://www.freecodecamp.com/challenges/show-the-local-weather)

Issue Description

Currently, the project challenges have an ordered list, listing the requirements and instructions for the challenge. However, I think there are too many "lists" as there is a bulleted list and the numerical list.

Firstly, I remember reading someone making an issue or comment on how the rule numbers usually make a weird contrast with its list number, like so where Rule #1 is listed as #2 in the list:

image

Secondly, there appears to be a redundancy in "lists," where you have the check boxes but also the numbered list items. Each item is already separated by spaces so I don't think you really need the numbers.

Numbers in a list, in my opinion, should have some meaning to it like needing to know there are 3 or 4 requirements for something. But in this case, the numbers don't really tell you much except there are 10 or so lines to read, which knowing the number is inconsequential to solving the challenge.

Proposed Fix

Change the ordered list to an unordered one. To make these changes, I think all we'd need to do is change this line from ol to ul (correct me if I'm wrong). Overall, I think these changes will give a cleaner look to the challenges.

Screenshot

Currently:
image

Proposed Change:
image

cc/ @hallaathrad

@erictleung erictleung added status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. scope: UI Threads for addressing UX changes and improvements to user interface labels May 31, 2016
@ghost
Copy link

ghost commented May 31, 2016

I think this is a lot better!

@s0nskar
Copy link

s0nskar commented May 31, 2016

can i try this or there is more discussion on this ??

@ghost
Copy link

ghost commented May 31, 2016

@Sanskar-Modi let's wait for @hallaathrad opinion!

@justincorrigible
Copy link
Member

justincorrigible commented May 31, 2016

Hmm haven't checked on all cases, but at least right now it makes a lot of sense to me. I'd say we take it, and then if any specific challenge requires an ordered list, we go an fix it on a case by case.
LGTM.


PS: While we're at it, can we try to figure out whether we actually need checkboxes? Most of the time they've seemed pointless to me in a practical sense.

@erictleung
Copy link
Member Author

We could probably go without the checkboxes as well.

image

We could probably center the list a little as well. I just did a quick HTML change to show what it'll look like.

@justincorrigible
Copy link
Member

Perfect, now a matter of removing the space on the left of the list, and we should be golden.
what do you think @FreeCodeCamp/issue-moderators ?

@raisedadead
Copy link
Member

Yup, lets save some more real estate!

@ghost
Copy link

ghost commented Jun 1, 2016

@hallaathrad @raisedadead, yeah let's do it!

@ghost ghost added help wanted Open for all. You do not need permission to work on these. and removed status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Jun 1, 2016
@ghost
Copy link

ghost commented Jun 1, 2016

@Sanskar-Modi, feel free to tackle this now! We have decided to remove the checkboxes and numbers.

Please, check our Guidelines for Contributing and if you need any assistance reach out to the Contributors Chat room.

@dhcodes
Copy link
Contributor

dhcodes commented Oct 5, 2016

Looks like this has been fixed. Reopen if I'm mistaken.

@dhcodes dhcodes closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
Development

No branches or pull requests

5 participants