Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially confusing wording/example on Portfolio Zipline instructions. #8767

Closed
Ramon-Carroll opened this issue May 22, 2016 · 6 comments
Closed
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@Ramon-Carroll
Copy link

Build a Personal Portfolio Webpage

https://www.freecodecamp.com/challenges/build-a-personal-portfolio-webpage

Issue Description

From my discussion with some members on the new forum here: http://forum.freecodecamp.com/t/portfolio-page-project-framework-usage/3128/, it appears that there is some confusion because the current portfolio example: https://codepen.io/FreeCodeCamp/full/YqLyXB/, appears that it may have been built on top of a template: http://blackrockdigital.github.io/startbootstrap-freelancer/, while the instructions, particularly number 10 (Not listed as one of the rules, by the way.) seems to discourage the use of a template:

There are many great portfolio templates out there, but for this challenge, you'll need to build a portfolio page yourself. Using Bootstrap will make this much easier for you.

The portfolio example does add in a decent amount of customization, so it doesn't look like a complete copy/paste. Perhaps the wording in the instructions should be modified, then?

@erictleung
Copy link
Member

@Ramon-Carroll I think there is vagueness within the instructions so that the portfolio (and the other more challenging projects) can be your own. You have the freedom to make it however you want. But I guess there could be more clarification.

How might you change the wording to make it more clear?

@erictleung erictleung added the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label May 23, 2016
@Ramon-Carroll
Copy link
Author

Ramon-Carroll commented May 23, 2016

@erictleung

Hi there, Eric. Well, perhaps we could go with something more like this maybe:

There are many great portfolio templates out there already. However, as an added challenge and learning opportunity, you could consider building the portfolio page from the ground up yourself. Using Bootstrap can help make this process much easier for you.

Does this work, or is it too explicit?

@erictleung
Copy link
Member

@Ramon-Carroll I wouldn't want to suggest that "as an added challenge" to do it from the ground up, but rather it is a learning opportunity. Maybe change it to:

There are many great portfolio templates out there already. However, you should consider building your portfolio page as much as you can from the ground up. Using Bootstrap can help make this process much easier for you.

@Ramon-Carroll
Copy link
Author

@erictleung That sounds cool too! Most importantly, it's clear. I'm interested in trying my hand at a pull request for this project, but I'm not exactly sure where it is in the source. Do you know where this is located?

@erictleung
Copy link
Member

@Ramon-Carroll here's the line you need to change.

Please first read the contributing guidelines before taking care of this issue. And feel free to visit the Contributors Help chat room if you have any questions about helping. We're there to help.

@erictleung erictleung added help wanted Open for all. You do not need permission to work on these. confirmed and removed status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Jun 1, 2016
@Ramon-Carroll
Copy link
Author

Ramon-Carroll commented Jun 1, 2016

@erictleung Ok, I understand. Thank you very much. I'm working on this.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

No branches or pull requests

3 participants