Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Progress Reset Modal #53959

Closed
naomi-lgbt opened this issue Mar 2, 2024 · 4 comments · Fixed by #54542
Closed

Clarify Progress Reset Modal #53959

naomi-lgbt opened this issue Mar 2, 2024 · 4 comments · Fixed by #54542
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface

Comments

@naomi-lgbt
Copy link
Member

The modal currently lists everything that will be reset in a single block of text:

image

We should update this to be a bit more clear. Maybe a list:

image

Verbiage can be discussed here, or iterated over in a PR to close this issue.
@naomi-lgbt naomi-lgbt added help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels Mar 2, 2024
@SaintPeter
Copy link
Member

It might make sense to include this in this proposed change #47464

@JBhrayn
Copy link
Contributor

JBhrayn commented Mar 4, 2024

@naomi-lgbt I agree with you. I just have few suggestions, such as keeping the text short and adjusting the alignment of list.
Let me know what you think about this (and if I could make a PR on this too):
image
image

@SaintPeter
Copy link
Member

@JBhrayn That looks good.

I wonder if we should also add clarification to the Danger Zone area as well:
image

I don't like the idea that you have to push a really dangerous looking button to find out what it will do. We don't even say that there will be a confirmation modal. I was didn't even want to click it for testing, since I have a huge amount of stuff on my personal account.

@Sembauke
Copy link
Member

Sembauke commented Mar 7, 2024

Lets go with @JBhrayn idea.

@RavidYael RavidYael mentioned this issue Mar 13, 2024
Closed
4 tasks
@huyenltnguyen huyenltnguyen mentioned this issue Apr 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
Milestone
No milestone
4 participants
@SaintPeter @Sembauke @naomi-lgbt @JBhrayn