Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project solutions are missing from certified user data #54162

Open
huyenltnguyen opened this issue Mar 21, 2024 · 10 comments
Open

Project solutions are missing from certified user data #54162

huyenltnguyen opened this issue Mar 21, 2024 · 10 comments
Labels
help wanted Open for all. You do not need permission to work on these. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@huyenltnguyen
Copy link
Member

Description

Some project solutions are broken / missing from certified user data, and we have an error message next to those projects.

Screenshot Screenshot 2024-03-21 at 14 15 17

Projects with broken solution are:

  • Responsive Web Design
    • Build a Survey Form
    • Build a Tribute Page
    • Build a Technical Documentation Page
    • Build a Product Landing Page
    • Build a Personal Portfolio Webpage
  • Relational Database
    • Celestial Bodies Database
    • World Cup Database
    • Salon Appointment Scheduler
    • Periodic Table Database
    • Number Guessing Game
  • Legacy Front End
    • Build a Personal Portfolio Webpage
    • Build a Tribute Page

We also have some projects which don't have a solution (the solution column is empty, rather than displaying an error message).

Screenshot Screenshot 2024-03-21 at 14 17 08

Projects with broken solution are:

  • JavaScript Algorithms and Data Structures (Beta)
    • Build a Palindrome Checker
    • Build a Roman Numeral Converter
    • Build a Telephone Number Validator
    • Build a Cash Register
    • Build a Pokémon Search App
  • Quality Assurance
    • Sudoku Solver
    • American British Translator
  • Scientific Computing with Python
    • Arithmetic Formatter
    • Time Calculator
    • Budget App
    • Polygon Area Calculator
    • Probability Calculator
  • Data Analysis with Python
    • Mean-Variance-Standard Deviation Calculator
    • Demographic Data Analyzer
    • Medical Data Visualizer
    • Page View Time Series Visualizer
    • Sea Level Predictor
  • Information Security
    • Port Scanner
    • SHA-1 Password Cracker
    • Secure Real Time Multiplayer Game
  • Machine Learning with Python
    • Rock Paper Scissors
    • Cat and Dog Image Classifier
    • Book Recommendation Engine using KNN
    • Linear Regression Health Costs Calculator
    • Neural Network SMS Text Classifier
  • College Algebra with Python
    • Build a Multi-Function Calculator
    • Build a Graphing Calculator
    • Build Three Math Games
    • Build a Financial Calculator
    • Build a Data Graph Explorer

Affected Page

In development environment and on /settings#certification-settings.

@huyenltnguyen huyenltnguyen added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Mar 21, 2024
@Sembauke Sembauke added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Apr 12, 2024
@KaterinaNakou2003
Copy link

is the issue still open? I want to work on it

@ilenia-magoni
Copy link
Contributor

@KaterinaNakou2003 We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.

Issues labeled with help wanted or first timers only are open for contributions.

Please make sure you read our guidelines for contributing. We prioritize contributors following the instructions in our guide. Join us in our chat room or the forum if you need help contributing - our community will be happy to assist you.

@Deep512
Copy link
Contributor

Deep512 commented May 2, 2024

@ilenia-magoni Correct me if I'm wrong, but I understand that we have to show an error message in case of no solution.
Is there anything to be done about the broken/missing solution?

@ilenia-magoni
Copy link
Contributor

@Deep512 no, the certified user data has to contain the project solutions

@RavidYael
Copy link

RavidYael commented May 6, 2024

Hi @ilenia-magoni,

I've started addressing the issue and have a couple of questions based on your last comment about the certified user data needing to contain project solutions.

1. Critical Question: Are you certain this is only a development environment issue and not present in production? Currently, the code doesn't make the solution field mandatory, and from a quick glance at curriculum.json, I noticed some challenges entirely lack a solution attribute. This raises concerns that this issue could also exist in production. If so, perhaps better error handling, as suggested by @Deep512, might be a good approach.

2. Potential Solution: How do you suggest we approach fixing this issue given that numerous challenges currently lack solutions?

Thanks in advance!

@ilenia-magoni
Copy link
Contributor

ilenia-magoni commented May 6, 2024

this issue is specifically to add the missing data to the mocked user @RavidYael , as such it can't be present in production. The mocked user is missing data as it has not been updated for the latest releases. The only saved solutions are those of final projects, as such we don't care that many challenges lack solutions, those solutions are not saved for each user, so they don't matter for the mocked user.

I am not sure you understand what this issue is about with this question. This is to update the certified-user with which the database can be seeded in the development environment.

@RavidYael
Copy link

I understand, in production, we will present the actual solution of the user. Thanks for clarifying!

@ilenia-magoni
Copy link
Contributor

@RavidYael we do not give solutions to users, and this issue is impossible in production because it's about the script that creates a false user data in the development database

@RavidYael
Copy link

I'm not sure I fully understand. When a user completes the "Build a Survey Form" project, what would they see in the solution section in production?
image

@a2937
Copy link
Member

a2937 commented May 6, 2024

@RavidYael There would be a "View" button that opens a link to their completed solution to the challenge. Like below. The user in the development database does not have a proper completed solution, as such it provides an error.

image

The user in the development database does not have a proper completed solution, as such it provides an error message. Are you with me so far?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

No branches or pull requests

7 participants