New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeCodeCamp profile is missing indications of fields #47847
Comments
Hey @ieahleen How do I get to that profile you displayed in your first pic? |
Thank you @bbsmooth , it's at freecodecamp.org/ieahleen |
There are quite a few accessibility issues with this profile page, but I'll stick to the topic at hand. For the personal information displayed in your first pic above, there is no requirement that you need to label what each of these are. Yes, it is not clear what some of these are, but it is not clear for everyone, regardless of how you are accessing the page, so there is no accessibility issue here since everyone experiences this ambiguity. The decision as to whether you want to label these to make it clearer is a usability issue. If we want to make sure that everyone understands what these are then we should label them. If we are fine with the ambiguity then we can leave them as is. |
I think I would prefer to leave this how it is - but I'm not against adding some labels either. That looks pretty decent. I wonder if it would look better with the colons all lined up - e.g. the colon ( |
It's not terrible as is, but I think there's room for improvement. However, I'm not sure we need labels for all of them, since Name should be self-explanatory and About probably is, too. That said, Location being the only one with a text label looks a little strange. We could try using a icon (with aria-label) for Location and see how that looks. @ahmadabdolsaheb what do you reckon? |
I went ahead and submitted a PR with these changes, if everyone else thinks we shouldn't need the labels, I can close the PR. If everyone approves of the changes, if I could get a hacktoberfest label applied, that would be great! |
I wonder if we should do away with the streak. It's always been a little inconsistent - although, I do know it motivates some people so maybe it's fine. |
I like Ahmad's design here - but it also doesn't include any labels. So I think we are probably leaning towards not adding labels. I looked a few profiles quick - twitter, github, our forum - they don't really include labels either. But they do seem to universally use some icons to indicate things where applicable... Our current profile pages have some icons already, so I would vote to stick with those. We could find an icon for each of the areas - or maybe just the location can have one of those drop pins or something. Wondering if we should have this issue focus on adding some icons and make another for the redesign, or just do the redesign here. |
That is a great observation. I tried to fit the join dated, location, and the socials in one line that is why I dropped the icons. |
For this specific issue, I think we should either add another icon for the location, or just leave it all as is and close this - and create a separate issue for the redesign. |
That is a good idea. As Ilenia mentioned, the Profile info is not presented well. It would be better if we focus our attention to a redesign. I am closing this issue in favor of #48234 |
When you read a profile it's not clear that those are Name, Location, About
Maybe @bbsmooth can give some accessibility indications?
The text was updated successfully, but these errors were encountered: