Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image link in React Markdown Previewer example project #42226

Closed
lasjorg opened this issue May 23, 2021 · 8 comments
Closed

Update image link in React Markdown Previewer example project #42226

lasjorg opened this issue May 23, 2021 · 8 comments
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@lasjorg
Copy link
Contributor

lasjorg commented May 23, 2021

The Markdown React example project has an image link (React logo) that no longer works. The link is using Google URL Shortener and redirects to some WP site.

https://goo.gl/Umyytc
https://techchronos.com/wp-content/uploads/SszarkLabs/stack-icon/cywBkaGwkMeDAuJbSt1k.png

Not sure if we should add the logo to our CDN, or just use something like commons.wikimedia.org for the link?

The logo is licensed under Creative Commons Attribution 4.0 (GitHub issue)
https://github.com/reactjs/reactjs.org/blob/master/LICENSE-DOCS.md

https://commons.wikimedia.org/wiki/File:React-icon.svg
@lasjorg lasjorg added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. scope: projects-frontend and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels May 23, 2021
@suburban-daredevil
Copy link
Contributor

Hello @lasjorg. I would like to work on this issue. Can you please assign this issue to me? Thank you!

@ShaunSHamilton
Copy link
Member

@suburban-daredevil

An issue with the help wanted or first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.

If you would like to contribute, and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/

If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum

As this issue requires access to the freeCodeCamp CodePen account, a member of staff will have to get to it. Hope this clarifies

@suburban-daredevil
Copy link
Contributor

Hello @ShaunSHamilton. Thanks for clarifying!

@lasjorg
Copy link
Contributor Author

lasjorg commented May 27, 2021

I'm still not sure if we should use the CDN or not? As far as I can tell, the logo license should allow us to have a copy on the CDN repo.

I might just open a PR and see if anyone has any concerns or not.

@ShaunSHamilton
Copy link
Member

I'm still not sure if we should use the CDN or not?

Me neither. I will defer to others on this.

I might just open a PR and see if anyone has any concerns or not.

If you mean to add to the CDN, then by all means.

@lasjorg
Copy link
Contributor Author

lasjorg commented May 27, 2021

PR freeCodeCamp/cdn#72

@lasjorg
Copy link
Contributor Author

lasjorg commented May 27, 2021

Come to think of it. It doesn't have to be the React logo. Maybe we should just use the fCC logo instead?

@lasjorg lasjorg mentioned this issue May 28, 2021
Merged
10 tasks
@moT01
Copy link
Member

moT01 commented Jun 11, 2021

Closed via the linked merged PR

@moT01 moT01 closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@moT01 @lasjorg @ShaunSHamilton @suburban-daredevil