Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor elements missing href attribute in challenge guide #38876

Closed
tannerdolby opened this issue May 23, 2020 · 11 comments
Closed

Anchor elements missing href attribute in challenge guide #38876

tannerdolby opened this issue May 23, 2020 · 11 comments
Labels
type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@tannerdolby
Copy link

tannerdolby commented May 23, 2020

Describe the bug
I found a few more broken links in the challenge guide for Intermediate Algorithm scripting.

To Reproduce

  1. Go to freeCodeCamp Challenge Guide: Sorted Union
  2. Click solution number 4, labeled 'JS While Loop'.
  3. Encounter the anchor element missing its href attribute

Next Bug

  1. Go to freeCodeCamp Challenge Guide: Smallest Common Multiple
  2. Click solution 1 and scroll to the list element in relevant links 'String.length'
  3. Encounter the anchor element is missing its href.

Next Bug

  1. Go to freeCodeCamp Challenge Guide: Missing letters
  2. Scroll to right under the problem explanation in Relevant links and view the 'String.fromCharCode'
  3. Encounter this anchor element is missing href attribute.
  4. On same page, click solution number 1,
  5. Go to relevant links and view list item 'String.length'
  6. Encounter the anchor element is missing an href attribute.
  7. Lastly for this page, Click solution number 3
  8. Encounter the error within relevant links 'JS Regex Resources' missing href attribute.

Expected behavior
Anchor elements are expected to have href attributes set for expected hyperlink behavior.

Screenshots
Screenshots are not necessary for this issue to be resolved. To reproduce section specifies exactly where bugs are located.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: chrome
  • Version: Version 81.0.4044.138 (Official Build) (64-bit)
@tannerdolby tannerdolby added the type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. label May 23, 2020
@rajat641
Copy link
Contributor

Hi @tannercd ,
I could reproduce all the issues you have mentioned and I found that <a href="proper_link"> is missing in the code.
I am fixing it now.

@tannerdolby
Copy link
Author

Hi @rajat641 ,

Ok great. Thank you for providing the fix. Let me know if I should close the issue myself or if you will close it upon completion.

@rajat641
Copy link
Contributor

Hi @tannercd ,
I'll close this upon completion.

@rajat641
Copy link
Contributor

Hi @moT01 ,
Can you give me a little hint on how to reproduce this locally??

@scissorsneedfoodtoo
Copy link
Contributor

Hi @tannercd, thanks for reporting this and for your detailed rundown. Makes it much easier to fix these broken links.

@rajat641, these all seem to be related to challenge guides on the forum. The permissions to edit each post are quite high, so a moderator will have to go in and fix each link.

I'll go through each of these and fix the links.

@scissorsneedfoodtoo
Copy link
Contributor

Just finished updating these links. Thanks again for creating this issue, @tannercd.

Could you or @rajat641 go through and confirm all the links are working and pointing to relevant guide articles?

Will close this issue for now, but please @ mention me if you notice any issues.

@tannerdolby
Copy link
Author

Hi @scissorsneedfoodtoo, you're welcome. I tried to provide as much detail as possible since I'm not able to update the wiki at my current permission level.

I just checked out each of the updated links and everything is working. All bugs fixed. Thank you for closing this issue. Cheers!

@rajat641
Copy link
Contributor

Thanks a lot @scissorsneedfoodtoo . I was trying to understand the code for 2-3 hours and ended up finding nothing and So I commented here. It saved my time.

@scissorsneedfoodtoo
Copy link
Contributor

scissorsneedfoodtoo commented May 27, 2020

Thanks for confirming all the links are working @tannercd. Your details made it really easy to find and fix them. Please feel free to open another issue if you find more broken links and @ mention me.

Sure, no problem @rajat641. Sorry for the confusion. The code in this repo mostly pertains to the /learn app. The Ghost theme for /news is in another repo and /forum is run on Discourse, and is almost completely independent from the other two applications.

It's a little extra confusing because we usually encourage people to raise any issues here in the main repo since it's the most visible. Hope that helps clear the air a little bit, and looking forward to your next contribution 👍 👍

@tannerdolby
Copy link
Author

No problem @scissorsneedfoodtoo . I'm glad I was able to help. If I find anymore broken links on the forum or challenge guides I will create an issue and @ mention you. Thanks again!

@scissorsneedfoodtoo
Copy link
Contributor

@tannercd, great! Please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

No branches or pull requests

3 participants