Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCC Advanced Node and Express not working? #16915

Closed
clickingmouse opened this issue Mar 19, 2018 · 4 comments
Closed

FCC Advanced Node and Express not working? #16915

clickingmouse opened this issue Mar 19, 2018 · 4 comments
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@clickingmouse
Copy link

not passing the tests when i am fairly sure my code should work

Challenge Name

https://beta.freecodecamp.org/en/challenges/advanced-node-and-express/set-up-a-template-engine
https://beta.freecodecamp.org/en/challenges/advanced-node-and-express/use-a-template-engines-powers
https://beta.freecodecamp.org/en/challenges/advanced-node-and-express/set-up-passport

Issue Description

just can't pass them, I am almost certain my code is okay

Browser Information

iMac, chrome

  • Browser Name, Version:
  • Operating System:
  • Mobile, Desktop, or Tablet:

Your Code

https://glitch.com/edit/#!/tan-bow?path=server.js:41:2

Screenshot
@raisedadead
Copy link
Member

raisedadead commented Mar 19, 2018 •
edited

Hi @Em-Ant just tagging you along for an analysis?

@raisedadead raisedadead added help wanted Open for all. You do not need permission to work on these. beta status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Mar 19, 2018
@Em-Ant
Copy link
Member

Em-Ant commented Mar 24, 2018 •
edited

Ok. @clickingmouse your code seems to be correct. The problem is that the domain https://beta.freecodecamp.org is not included in the list of CORS enabled domains in the boilerplate.
If you want you can try to add it in the array at freeCodeCamp/fcctesting.js:44:28, and the tests will pass.

@raisedadead I opened a PR for this.

@Em-Ant Em-Ant mentioned this issue Mar 24, 2018
Merged
@clickingmouse
Copy link
Author

Cool, it seems to solve it for for the first challenge

@sagarjaspal
Copy link

This wasn't working for https://learn.freecodecamp.org/ too! Thanks for the help!

raisedadead pushed a commit to freeCodeCamp/boilerplate-advancednode that referenced this issue Jun 20, 2018
@Em-Ant @raisedadead
fix cors domain for beta and freecodecamp.org (#1)
944fa66 
add `https://www.freecodecamp.org` and `https://beta.freecodecamp.org` to the CORS enabled domains to access the boilerplate. 

Closes freeCodeCamp/freeCodeCamp#16915
shartrooper added a commit to shartrooper/Passport-Pug-Socket-playground that referenced this issue Aug 17, 2020
@shartrooper @Em-Ant @ojeytonwilliams
merging to master (#1)
302f717 
* Initial commit with Gomix

* fix cors domain for beta and freecodecamp.org (#1)

add `https://www.freecodecamp.org` and `https://beta.freecodecamp.org` to the CORS enabled domains to access the boilerplate. 

Closes freeCodeCamp/freeCodeCamp#16915

* Fix create new middleware test #2

Co-authored-by: System <none>
Co-authored-by: Emanuele Antonelli <joshua999x@gmail.com>
Co-authored-by: Skip Hendriks <sigmar001@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@raisedadead raisedadead removed the status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@QuincyLarson @raisedadead @Em-Ant @sagarjaspal @clickingmouse