Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences Between the var and let Keywords lesson has unnecessary note #16893

Closed
yoizfefisch opened this issue Mar 13, 2018 · 3 comments
Closed
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Comments

@yoizfefisch
Copy link

Challenge Name

ES6: Explore Differences Between the var and let Keywords

Issue Description

At the bottom of the lesson there is a note:

Remember that since let prevents variables from being overridden, you will need to remove one of the declarations entirely.

But in the code, none of the variables are decalred more than once.

@raisedadead raisedadead added help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Mar 14, 2018
@raisedadead
Copy link
Member

I think the note is redundant here. This can be removed.

Here are our Guidelines for Contributingand you can reach us in the Contributors Chat room for help.

@raisedadead
Copy link
Member

First time contributors, you can simply use the search at the top of this page to look for the string in the note to identify the file that needs changing.

@muratdogan17
Copy link
Contributor

I'm working on it 👍

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 14, 2018
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

No branches or pull requests

4 participants