Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] Applied Accessibility - Tests fail to check for closing </nav> tag #16415

Closed
Asjas opened this issue Jan 5, 2018 · 3 comments
Closed

[Beta] Applied Accessibility - Tests fail to check for closing </nav> tag #16415

Asjas opened this issue Jan 5, 2018 · 3 comments
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@Asjas
Copy link
Contributor

Asjas commented Jan 5, 2018 •
edited

Challenge Name

https://beta.freecodecamp.org/en/challenges/applied-accessibility/make-screen-reader-navigation-easier-with-the-nav-landmark

Issue Description

There are two issues I've found here.

Firstly, One of the tests says there shouldn't be any <div> tags used in this code. If a closing </div> tag is left in the code the test passes.

Secondly, If you use a opening <nav> tag and leave out the closing </nav> tag the test also passes.

Browser Information

  • Browser Name, Version: Chrome, Version 63.0.3239.108 (Official Build) (64-bit)
  • Operating System: Windows 10 Pro
  • Mobile, Desktop, or Tablet: Desktop

Your Code

<body>
  <header>
    <h1>Training with Camper Cat</h1>

    <nav>
      <ul>
        <li><a href="#stealth">Stealth &amp; Agility</a></li>
        <li><a href="#combat">Combat</a></li>
        <li><a href="#weapons">Weapons</a></li>
      </ul>
    </div>

  </header>
  <main>
    <section id="stealth">
      <h2>Stealth &amp; Agility Training</h2>
      <article><h3>Climb foliage quickly using a minimum spanning tree approach</h3></article>
      <article><h3>No training is NP-complete without parkour</h3></article>
    </section>
    <section id="combat">
      <h2>Combat Training</h2>
      <article><h3>Dispatch multiple enemies with multithreaded tactics</h3></article>
      <article><h3>Goodbye world: 5 proven ways to knock out an opponent</h3></article>
    </section>
    <section id="weapons">
      <h2>Weapons Training</h2>
      <article><h3>Swords: the best tool to literally divide and conquer</h3></article>
      <article><h3>Breadth-first or depth-first in multi-weapon training?</h3></article>
    </section>
  </main>
</body>

Screenshot

accessibility
@Asjas Asjas changed the title [Beta] Applied Accessibility - Tests failing to check for correct HTML tags in challenge [Beta] Applied Accessibility - Tests fail to check closing </nav> tag Jan 6, 2018
@Asjas Asjas changed the title [Beta] Applied Accessibility - Tests fail to check closing </nav> tag [Beta] Applied Accessibility - Tests fail to check for closing </nav> tag Jan 6, 2018
@raisedadead raisedadead added beta help wanted Open for all. You do not need permission to work on these. labels Jan 6, 2018
@matthras
Copy link

matthras commented Jan 17, 2018 •
edited

I've got one or two ideas for a fix - will be testing some changes locally for the next few days before I submit a pull request.

EDIT: Have been unable to get FCC working locally, so haven't made any progress. Don't wait on me!

@anhtran1906
Copy link
Contributor

anhtran1906 commented Jan 24, 2018 •
edited

I could reproduce the problem and successfully added tests for the </div> and </nav> tag. My solution is that I added two new lines of test to test if the user's answer includes </nav> and does not include </div>. @raisedadead please let me know if you're OK with this solution and I can create a pull request within the next 8 hours

@raisedadead
Copy link
Member

@matthras please reach out to Contributors Chat room, we will try and get your local setup up.

@anhtran1906 thanks for working on this. Please go ahead with a pull request, and we will guide with further feedback if needed.

Thanks and Happy contributing!

@anhtran1906 anhtran1906 mentioned this issue Jan 25, 2018
Merged
10 tasks
anhtran1906 added a commit to fccSeniorSeminar/freeCodeCamp that referenced this issue Jan 26, 2018
@anhtran1906
fix(seed): Add test cases for closing tags
036f6cf 
Added test cases with assert statements

BREAKING CHANGE: no

Closes freeCodeCamp#16415
Closes freeCodeCamp#16424
Closes freeCodeCamp#16423
Closes freeCodeCamp#16422
Closes freeCodeCamp#16420
Closes freeCodeCamp#16419
Closes freeCodeCamp#16417
Closes freeCodeCamp#16414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@raisedadead @Asjas @matthras @anhtran1906