-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to react-codemirror2 #16397
Comments
@BerkeleyTrue @QuincyLarson do you think this is okay for the road map? |
@raisedadead I haven't noticed any issues with react-codemirror. After all it is a thin wrapper around codemirror. That being said it looks like it might be worth the upgrade. I don't think this has anything to do with accessibility, though. |
Oh yes, it has nothing to with a11y, I just happened to link to the issue, incase we are patching CM as per discussions in the thread, this might be affected. Adding this to roadmap. |
@raisedadead @BerkeleyTrue One of the current problems with react-codemirror, is that if we ever want to upgrade to newer versions of React, react-codemirror will pretty much completely cease to work, as it has not been maintained at all since the early days of React. I tried to use react-codemirror for a project using React 16 and had considerable difficulty, and switching to react-codemirror2 instantly solved my problems. That said, can't remember what those problems were. |
@no-stack-dub-sack thanks for the info. Sounds like a solid reason to upgrade. |
Note we've switched to Monaco so I'm closing this issue. |
We should consider moving to https://github.com/scniro/react-codemirror2 which promises an actively maintained replacement of our current component.
Doing so is way better going forward as a part of preventive upgrades/maintainance.
Additional related topics:
The text was updated successfully, but these errors were encountered: