Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-codemirror2 #16397

Closed
raisedadead opened this issue Jan 2, 2018 · 6 comments
Closed

Upgrade to react-codemirror2 #16397

raisedadead opened this issue Jan 2, 2018 · 6 comments
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@raisedadead
Copy link
Member

We should consider moving to https://github.com/scniro/react-codemirror2 which promises an actively maintained replacement of our current component.

  • The current component maintainers are non-responsive about all activities on their tracker and there is a discussion Deprecate react-codemirror JedWatson/react-codemirror#126 by the community of a more maintained version.
  • The replacement (react-codemirror2) maintainers are having codemirror as a peer dependency.

Doing so is way better going forward as a part of preventive upgrades/maintainance.

Additional related topics:

@raisedadead raisedadead added status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. enhancement labels Jan 2, 2018
@raisedadead
Copy link
Member Author

@BerkeleyTrue @QuincyLarson do you think this is okay for the road map?

@BerkeleyTrue
Copy link
Contributor

@raisedadead I haven't noticed any issues with react-codemirror. After all it is a thin wrapper around codemirror. That being said it looks like it might be worth the upgrade. I don't think this has anything to do with accessibility, though.

@raisedadead
Copy link
Member Author

Oh yes, it has nothing to with a11y, I just happened to link to the issue, incase we are patching CM as per discussions in the thread, this might be affected.

Adding this to roadmap.

@raisedadead raisedadead added status: on the roadmap Long term plans and features. help wanted Open for all. You do not need permission to work on these. and removed status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Jan 2, 2018
@no-stack-dub-sack
Copy link
Member

no-stack-dub-sack commented Jan 5, 2018

@raisedadead @BerkeleyTrue One of the current problems with react-codemirror, is that if we ever want to upgrade to newer versions of React, react-codemirror will pretty much completely cease to work, as it has not been maintained at all since the early days of React. I tried to use react-codemirror for a project using React 16 and had considerable difficulty, and switching to react-codemirror2 instantly solved my problems. That said, can't remember what those problems were.

@BerkeleyTrue
Copy link
Contributor

@no-stack-dub-sack thanks for the info. Sounds like a solid reason to upgrade.

@QuincyLarson
Copy link
Contributor

Note we've switched to Monaco so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

No branches or pull requests

4 participants