Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] Matching Braces color in the editor needs to be changed #16363

Closed
vkWeb opened this issue Dec 28, 2017 · 3 comments
Closed

[Beta] Matching Braces color in the editor needs to be changed #16363

vkWeb opened this issue Dec 28, 2017 · 3 comments
Labels
help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface

Comments

@vkWeb
Copy link
Member

vkWeb commented Dec 28, 2017

Issue Description

The matching braces color #00ff00 in the beta looks weird and after some time it becomes difficult to trace the matching pair. So, with my idea of adding a border around the matching braces like in VSCode, will resolve this issue.
Please, have a look at the below GIF's in fullscreen by clicking on them to notice the difference effectively. This issue will be addressed in my up-coming PR.

Default Setup:
before

After applying the proposed changes:
after

Browser Information

  • Browser Name, Version: Chrome(latest release) & Firefox(latest release).
  • Operating System: Windows 10 Pro 32 Bit.
  • Mobile, Desktop, or Tablet: Desktop

@QuincyLarson, @raisedadead Thoughts on this?

@systimotic systimotic added beta status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Dec 28, 2017
@QuincyLarson
Copy link
Contributor

QuincyLarson commented Dec 29, 2017

@vkWeb I agree this seems friendlier than the color change, and will look uniform on night mode as well :)

Thanks for spotting this issue and creating these gifs. Excellent issue!

@vkWeb
Copy link
Member Author

vkWeb commented Dec 30, 2017

@QuincyLarson Thank you so much :). I'll raise a PR for this as well.

vkWeb added a commit to vkWeb/freeCodeCamp that referenced this issue Jan 2, 2018
@raisedadead raisedadead added help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface and removed status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Jan 12, 2018
vkWeb added a commit to vkWeb/freeCodeCamp that referenced this issue Jan 12, 2018
@QuincyLarson
Copy link
Contributor

QuincyLarson commented Jun 3, 2018

Thanks for your help with this @vkWeb. We're now using a different code editor (Monaco) so this is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
Development

No branches or pull requests

4 participants