Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in "HTML5 and CSS: Use Hex Code for Specific Colors" #13581

Closed
eti8 opened this issue Feb 25, 2017 · 15 comments · Fixed by ananaymital/FreeCodeCamp#3
Closed

Typo in "HTML5 and CSS: Use Hex Code for Specific Colors" #13581

eti8 opened this issue Feb 25, 2017 · 15 comments · Fixed by ananaymital/FreeCodeCamp#3
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these.

Comments

@eti8
Copy link

eti8 commented Feb 25, 2017

https://www.freecodecamp.com/challenges/use-hex-code-for-specific-colors

"Like decimals, the symbols 0-9 represents values zero to nine."

It should be "...symbols 0-9 represent values...", right?

Otherwise, congratulations for the tremendous work on the site.
This is very helpful.

@Greenheart
Copy link
Member

@eti8 Thanks for reporting this!

Don't worry about the bot - we haven't taught it proper manners yet... 😄

I think an alternative might be "...symbols 0-9 represent the values...". What do you think?

@eti8
Copy link
Author

eti8 commented Feb 25, 2017

@Greenheart You're welcome.
It's the least I can do to show some gratefulness.

Yes, your alternative sounds even better.

@dhcodes dhcodes added first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. labels Feb 25, 2017
@dhcodes
Copy link
Contributor

dhcodes commented Feb 25, 2017

First-timers only:
Here's the line to change per @Greenheart's recommendation:

"We usually use <code>decimals</code>, or base 10 numbers, which use the symbols 0 to 9 for each digit. <code>Hexadecimals</code> (or <code>hex</code>) are base 16 numbers. This means it uses sixteen distinct symbols. Like decimals, the symbols 0-9 represent values zero to nine. Then A,B,C,D,E,F represent values ten to fifteen. Altogether, 0 to F can represent a digit in <code>hexadecimal</code>, giving us 16 total possible values. You can find more information about <a target='_blank' href='https://en.wikipedia.org/wiki/Hexadecimal'>hexadecimal numbers here</a>.",

Please follow the guidelines in the Contributing document

@Greenheart
Copy link
Member

@eti8 As you reported it, would you like to make an open source contribution and fix this? Me and other contributors would be happy to guide you through the process! 😄

See the links @dhcodes posted above for more info.

@orvi2014
Copy link

Can I contribute on this ?

@Greenheart
Copy link
Member

@orvi2014 Thanks for asking! 😊 If @eti8 doesn't want it, I'll ping you.

Meanwhile, see if you can find any issue you find interesting and mention me (@Greenheart) and I will help you get started 😊

@eti8
Copy link
Author

eti8 commented Feb 25, 2017

@Greenheart Yes, sure I'd be delighted to.

I'll go over the free series:
then the contribution guidelines
and come back to you when I'm ready.

Thanks for being available for guidance, I really appreciate it.

@abagwell
Copy link

Hi Guys, I am not seeing that issue. Has this one been resolved?

@eti8
Copy link
Author

eti8 commented Feb 26, 2017

@Greenheart I went through the videos and over some of the guidelines.
I won't be able to contribute to this issue and fix it anytime soon.
Please feel free to assign/ping it to someone else (@orvi2014 or @Bagzy or others).

Once trained and ready, I'll get back later this year to contribute to another issue/typo, I might spot as I'll progress through the tutorials.

Meanwhile, my best wishes to all, for their work and efforts.

@chrisjantzen
Copy link
Contributor

It looks like someone has fixed this, changing represents to represent as was initially suggested.

@erictleung
Copy link
Member

@XXiphias the change now incorporates the change with "the" to make it "represents the values..."

Whoever picks this might as well change the proceeding sentence as it is very similar to this issue.

- Then A,B,C,D,E,F represent values ten to fifteen.
+ Then A,B,C,D,E,F represent the values ten to fifteen.

ananaymital added a commit to ananaymital/FreeCodeCamp that referenced this issue Feb 27, 2017
This PR fixes the typo in "HTML5 and CSS: Use Hex Code for Specific
Colors". Issue fixed freeCodeCamp#13581
@Greenheart
Copy link
Member

Greenheart commented Feb 27, 2017

@eti8 You're welcome whenever you're ready! We'll be around in the Contributors chat room if you want to get in touch in the future.

Thanks, and happy coding! :)

@homerrowsky
Copy link
Contributor

Hi. Is this still open? It's my first time. I'm trying to get the modification @erictleung suggested (line 3124) done.

Saludos!!

@erictleung
Copy link
Member

@homerrowsky yes, this is still open. Someone worked on it but referenced their own fork of the project rather than this main repository.

@sfxgg
Copy link

sfxgg commented Mar 7, 2017

If this isn't done by later tonight I'll go ahead and work on this if that's alright. Nevermind, @erictleung handled it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants