Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Test error: Intermediate Algorithm Challenge - Missing Letters #13431

Closed
fixtheelvis opened this issue Feb 18, 2017 · 3 comments · May be fixed by MaxMood96/freeCodeCamp#35
Closed

[beta] Test error: Intermediate Algorithm Challenge - Missing Letters #13431

fixtheelvis opened this issue Feb 18, 2017 · 3 comments · May be fixed by MaxMood96/freeCodeCamp#35
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@fixtheelvis
Copy link

The test fearNotLetter("abcdefghjklmnopqrstuvwxyz") is supposed to return undefined because there's supposed to be no letters missing in the string. However, the letter "i" is very clearly missing. My solution is correct and passes all tests and returns undefined when the string above has the missing i.

I hope this helps you guys catch this error

@Greenheart
Copy link
Member

@fixtheelvis Thanks for reporting this - What a catch! 😮

Don't mind the bot, we haven't taught it proper manners yet! 😄

Here's the assertion for the test case you are refferring to:

assert.isUndefined(fearNotLetter('abcdefghijklmnopqrstuvwxyz'), 'message: <code>fearNotLetter(\"abcdefghjklmnopqrstuvwxyz\")</code> should return undefined.');

As you can see, each test case concists of an assertion with something that evaluates to true/false and a message. In this case, the message is supposed to show the full sequence - but as you pointer out, it's missing the letter i. Since it's part of the message-string, it's visible to campers (at least those who catch it!), but it won't affect the assertion. That's why the test still passes.

Since you caught this error, would you like to make a contribution and fix it? Me and other contributors would be happy to guide you through the process! 😄

@raisedadead raisedadead changed the title Test error: Beta FreecodeCamp Intermediate Algorithm Challenge - Missing Letters [beta] Test error: Intermediate Algorithm Challenge - Missing Letters Feb 24, 2017
@raisedadead raisedadead added the help wanted Open for all. You do not need permission to work on these. label Feb 28, 2017
@Quinn-H
Copy link
Contributor

Quinn-H commented Mar 3, 2017

Hi, @Greenheart @raisedadead Can I fix this issue ?

@Greenheart
Copy link
Member

@Quinn-H Thanks, that would be awesome!

See CONTRIBUTING.md for help getting started and come chat with us in the contributors chat room if you have any questions.

Happy coding! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants