Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Test passes without conditions being met #12814

Closed
gt6089 opened this issue Jan 24, 2017 · 3 comments
Closed

[beta] Test passes without conditions being met #12814

gt6089 opened this issue Jan 24, 2017 · 3 comments

Comments

@gt6089
Copy link

gt6089 commented Jan 24, 2017

CHALLENGE:
http://beta.freecodecamp.com/en/challenges/css-flexbox/using-the-flexdirection-property-to-make-a-row

ISSUE:
Clicking 'Run tests' button passes the tests without the test conditions being met. I did not add the CSS property flex-direction to the #box-container element, and give it a value of row.

BROWSER INFO:

  • Chrome 55.0.2883.87 m
  • Windows 7
  • Desktop

SCREENSHOT:
image

@gt6089
Copy link
Author

gt6089 commented Jan 24, 2017

In fact, it looks like changing the code to meet the test conditions has no effect on the screen preview. The container elements continue to show as columns. This also seems to be true of the next challenge at least, Css Flexbox: Applying the Flex-direction Property to Create Rows in the Tweet Embed.

Incidentally, I need to click 'run tests' to see what I'm working with as the screen preview is blank on initial page load. Clicking 'run tests' populates the preview.

@dhcodes
Copy link
Contributor

dhcodes commented Jan 25, 2017

@gt6089 Thanks for the issue. I believe this is very similar to #12803 where @ananaymital has pointed out that flex-direction defaults to row. We should work on a fix for both of these.

@dhcodes dhcodes changed the title Test passes without conditions being met [beta] Test passes without conditions being met Jan 25, 2017
@HKuz
Copy link
Member

HKuz commented Jan 26, 2017

@gt6089 @dhcodes - I've consolidated a number of the related Flexbox issues over in #12803. We have someone working on a fix (including this issue), and hopefully resolve this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants