Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile is logging challenges for the wrong date. #12589

Closed
zanydjaygurl opened this issue Jan 18, 2017 · 6 comments
Closed

Profile is logging challenges for the wrong date. #12589

zanydjaygurl opened this issue Jan 18, 2017 · 6 comments
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@zanydjaygurl
Copy link

zanydjaygurl commented Jan 18, 2017

Challenge Declare JavaScript Variables has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36.

I'm on the East coast of the US at 10:15PM EST on 01/17/2017, and I am completing my challenges for today, but they are logged on my profile as being completed on 01/18/2017. This restarted my streak, and I would like to keep it going :'(. Can anybody help, please? Thank you!

@no-stack-dub-sack no-stack-dub-sack added confirmed status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Jan 18, 2017
@no-stack-dub-sack
Copy link
Member

no-stack-dub-sack commented Jan 18, 2017

@zanetagrant Thanks for reporting this. This is an interesting issue. Unfortunately, though, I'm not sure that anyone will be able to correct your streak for the time being 😦

@freeCodeCamp/moderators
has this come up before? I feel like I may have seen a similar issue in the past, but just ran a quick search and couldn't find a closed issue that was similar Scratch that, I did find 2 similar issues, but neither is resolved - #7468 seems to suggest that streak should be calculated by local time when users are logged in, but it still looks like its going by server time, as I was logged in when I reproduced this. #7346 addresses this as well but also did not go anywhere.

Anyone have any thoughts?

I was able to confirm this with a second account that I have accidentally had for a while now (if you're wondering why it's so empty), completed the challenge about 10 min before midnight, also US EST:
image

@sludge256
Copy link
Contributor

We've had a few PRs in regards to this and similar issues before. I'm not sure what the current status or plan is on dealing with the discrepancies.

@no-stack-dub-sack
Copy link
Member

@raisedadead I believe you were looking at one of the issues mentioned above ☝️
Do you recall what, if anything, was decided?

@raisedadead
Copy link
Member

Well, mostly other priority issues took over that particular one, and it's still an open issue.

The whole point being there is an obvious difference when the user is logged in and when they are not. The whole trouble is mentioned in #7468 (comment)

That is still the case to the best of my knowledge.

At the best this being a huge UX issue, needs a major refactor in the way we store the progress points and plot them on the streak graph. This can now be more viable because, we are moving to react, and will being doing lesser things server side.

I think @Bouncey can guide on what's needed more. But at the best this is the birds-eye view of the current status.

@Bouncey
Copy link
Member

Bouncey commented Jan 18, 2017 via email

@raisedadead
Copy link
Member

raisedadead commented Feb 23, 2017

I'll close this in favor of #7925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Development

No branches or pull requests

5 participants