Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Night mode should be active on page load #12560

Closed
systimotic opened this issue Jan 16, 2017 · 1 comment
Closed

[beta] Night mode should be active on page load #12560

systimotic opened this issue Jan 16, 2017 · 1 comment
Assignees
Labels
help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface

Comments

@systimotic
Copy link
Member

We're on a roll with improving the night mode! 馃憤

Issue Description

When the page has to load (when coming from a page that is not reactified, first opening the page or reloading), it takes a bit for the night mode to active. This flash of light can be a bit annoying I must say 鈿★笍 馃槄

I'm not certain about the cause, or what a solution would be.

#12538 (comment)
/cc @Bouncey

@Bouncey
Copy link
Member

Bouncey commented Jan 16, 2017

We would need to look at the difference in how the production site does night mode and how to implement it into the react version so that night mode persists correctly between sessions

The delay on first load/reload is probably caused by the eval time of our bundle, which is HUGE! The time to first interaction (and night mode activating) is held up by the time it takes for react to take over from the server-side rendered html page. In this period, you might notice some 'jank' or juddering of the codemirror skeleton animation.

@Bouncey Bouncey added help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface labels Jan 16, 2017
@Bouncey Bouncey changed the title Night mode flash Night mode should be active on page load Jan 16, 2017
@raisedadead raisedadead changed the title Night mode should be active on page load [beta] Night mode should be active on page load Jan 21, 2017
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 7, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
Development

No branches or pull requests

4 participants