Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instructions for 'Counting Cards' #11819

Closed
VAggrippino opened this issue Nov 26, 2016 · 3 comments
Closed

Improve instructions for 'Counting Cards' #11819

VAggrippino opened this issue Nov 26, 2016 · 3 comments
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these.

Comments

@VAggrippino
Copy link

VAggrippino commented Nov 26, 2016

No description provided.

@erictleung
Copy link
Member

@VAggrippino thanks for the issue.

...we haven't learned string to integer conversion at this point.

This isn't too much of an issue because JavaScript is dynamically untyped language. That is why you can code 3 + " Bet" and the interpreter will not yell at you for putting together different types (i.e. numeric plus string).

I understand your concern for consistency in dealing with just strings, rather than two data types, but I don't think it is too much of a concern for this challenge.

The only clarifying change to the instructions could be to add in that the input parameter card can be a numeric or string.

cc/ @FreeCodeCamp/moderators

@erictleung erictleung added the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label Nov 27, 2016
@Bouncey
Copy link
Member

Bouncey commented Nov 27, 2016

First-timers only

The code for this challenge is here.

The changes needs are:

You will write a card counting function. It will receive a card parameter , which can be a number or a string, and increment or decrement the global count variable according to the card's value (see table).

Following CONTRIBUTING.md will help you get set up and make your first PR to FreeCodeCamp 👍

If you get stuck, reach out to us in Contributors chat room

Good Luck!

@Bouncey Bouncey added first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. and removed status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Nov 27, 2016
@Bouncey
Copy link
Member

Bouncey commented Nov 27, 2016

@VAggrippino I was opening this issue up for anyone to create a PR. We would be grateful for any attempt to fix this, but if you are not up to it, someone else will create a PR. No pressure 👍

Happy Coding!

@Bouncey Bouncey reopened this Nov 27, 2016
@Bouncey Bouncey changed the title We should use strings for card values. Improve instructions for 'Counting Cards' Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

No branches or pull requests

3 participants