Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Solution Passes Tests #11787

Closed
Margaret2 opened this issue Nov 24, 2016 · 4 comments
Closed

Incorrect Solution Passes Tests #11787

Margaret2 opened this issue Nov 24, 2016 · 4 comments
Assignees
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@Margaret2
Copy link

Margaret2 commented Nov 24, 2016

Challenge Import a Google Font has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.100 Safari/537.36 Vivaldi/1.5.658.44.
Please describe how to reproduce this issue, and include links to screenshots if possible.

The instructions and tests for this challenge say that you should apply the Lobster font to the h2 element, but leave the p elements using Monospace.

So that implies that the correct solution is to create a selector that will target only the h2 elements:

<style>
  .red-text {
    color: red;
  }

  p {
    font-size: 16px;
    font-family: Monospace;
  }

h2 {
    font-family: Lobster;
}
</style>

However, this code passes even though it also changes the font of the p elements to Lobster.

<style>
  .red-text {
    color: red;
    font-family: Lobster, Monospace;
  }

  p {
    font-size: 16px;
    font-family: Monospace;
  }
</style>

<h2 class="red-text">CatPhotoApp</h2>

<p class="red-text">Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.</p>
<p class="red-text">Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.</p>

Should we modify the tests so that there has to be a separate h2 selector?

@Manish-Giri
Copy link
Contributor

Confirmed.

@ooade
Copy link

ooade commented Nov 24, 2016

Wow! It also applies to the next challenge: Specify How Fonts Should Degrade

@raisedadead
Copy link
Member

Good catch. Thanks @Margaret2 @Manish-Giri and @marhyorh.
Anyone up for fixing the tests on both challenges?

@raisedadead raisedadead added confirmed help wanted Open for all. You do not need permission to work on these. labels Nov 24, 2016
@dhcodes
Copy link
Contributor

dhcodes commented Nov 24, 2016

I'll take a crack at this. Been awhile since I made a contribution.

@BerkeleyTrue BerkeleyTrue added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed confirmed labels Nov 26, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

No branches or pull requests

6 participants