Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS issue with 13" (1280 x 659) viewports. #11687

Closed
raisedadead opened this issue Nov 17, 2016 · 4 comments
Closed

CSS issue with 13" (1280 x 659) viewports. #11687

raisedadead opened this issue Nov 17, 2016 · 4 comments
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@raisedadead
Copy link
Member

raisedadead commented Nov 17, 2016

Device:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36

Viewport : 1280 x 659

Issue :
image

This almost made be believe that the url is actually .co instead of a .com

@raisedadead raisedadead added confirmed help wanted Open for all. You do not need permission to work on these. labels Nov 17, 2016
@raisedadead
Copy link
Member Author

this must go against the backup/master and staging branches

@erictleung
Copy link
Member

We could use either <wbr> (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr) or an overflow-wrap (https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap). Previously for this kind of issue, we used the <wbr>. I haven't used overflow-wrap, but the example on MDN could make for a more long-term solution without having to manually add in <wbr> breaks in long word.

image

@chiptus
Copy link
Contributor

chiptus commented Nov 18, 2016

I'm on it.
I'm adding this rule to the .test-output class. It's working on the staging branch, should I do the change to master branch as well?

@raisedadead
Copy link
Member Author

raisedadead commented Nov 18, 2016

@chiptus thanks a lot for looking into this.

should I do the change to master branch as well?

Yes. But NOT master, check my earlier clarification:

this must go against the backup/master and staging branches

@BerkeleyTrue BerkeleyTrue added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed confirmed labels Nov 19, 2016
@systimotic systimotic removed their assignment Nov 19, 2016
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

No branches or pull requests

5 participants