Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding description for form-controls #10320

Closed
luongthomas opened this issue Aug 23, 2016 · 5 comments
Closed

Adding description for form-controls #10320

luongthomas opened this issue Aug 23, 2016 · 5 comments
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these.

Comments

@luongthomas
Copy link

luongthomas commented Aug 23, 2016

Challenge Name

https://www.freecodecamp.com/challenges/style-text-inputs-as-form-controls

Issue Description

This challenge would be a lot more informative if a description of what adding the form-control class to the input field actually does. Something along the lines of:

All textual [input], [textarea], and [select] elements with class [.form-control] have a width of 100%.

@ghost
Copy link

ghost commented Aug 23, 2016

This challenge is currently quite short and it's defiantly worth adding an explanation here.

To First Timer:
You will need to add the sentence under this line. Please, check our Guidelines for Contributing and if you need any assistance reach out to the Contributors Chat room.

Note: You can only submit a pull request for this issue if you are new and haven't submitted one before. Hence the issue label first-timers-only 😜

@ghost ghost added help wanted Open for all. You do not need permission to work on these. first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Aug 23, 2016
@erictleung
Copy link
Member

The code you'll need to add specifically is

"All textual <code>&lt;input&gt;</code>, <code>&lt;textarea&gt;</code>, and <code>&lt;select&gt;</code> elements with the class <code>.form-control</code> have a width of 100%."

It should render as

All textual <input>, <textarea>, and <select> elements with the class .form-control have a width of 100%.

n-white added a commit to n-white/FreeCodeCamp that referenced this issue Aug 24, 2016
@n-white
Copy link
Contributor

n-white commented Aug 24, 2016

Hey there. I'm a first-timer interested in getting started with contributing to Free Code Camp. I will submit a PR for this issue. Thanks!

@chakrihacker
Copy link

Hey What about tests ??
Tests should be added for each input.

@usersaurabh
Copy link

having issue in style-text-inputs-as-form-controls
just give a class="form-control" to

1) <form action="/submit-cat-photo" class="form-control">

2) <div class="row" class="form-control">
before your checkbox's 1st div i.e. <div class="col-xs-4">

and finally add here
3)<input type="text" placeholder="cat photo URL" class="form-control" required>

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Development

No branches or pull requests

5 participants