Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Newline Chars In Cell Content #105

Open
stephancasas opened this issue May 17, 2020 · 0 comments
Open

Unexpected Newline Chars In Cell Content #105

stephancasas opened this issue May 17, 2020 · 0 comments

Comments

@stephancasas
Copy link

If cell data contains a trailing whitespace character, four (4) additional newline chars will be appended to the text node inside of the dt-cell__content div. This can cause the text-overflow: ellipsis; CSS rule to engage prematurely, and will unnecessarily truncate the content of the cell.

It would seem that this is a result of using a template string to format the cell HTML. I've referenced line 864 of cellmanager.js where this is declared. Collapsing the template string to a single line should fix this issue. If this exceeds max line length, concatenating the variables prior to integrating into the template string may be another option.

return `
<div class="${className}">
${contentHTML}
${sortIndicator}
${resizeColumn}
${dropdown}
</div>
${editCellHTML}
`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant