Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a repeated schedule in student profile #165

Open
danfelbm opened this issue Sep 14, 2016 · 3 comments
Open

Removing a repeated schedule in student profile #165

danfelbm opened this issue Sep 14, 2016 · 3 comments
Labels

Comments

@danfelbm
Copy link

Hello there,

I've accidentally assigned the same course period to the same student two times, this didn't throw a error message; yet, it did create two entries in the Database. Schedule table doesn't have an index, so I can't remove the repeated entry, or can I?

In RosarioSIS, if I edit one entry, it modifies the other... I already have grades assigned to that student, is there any way I can remove the double entry?

Regards

@francoisjacquet
Copy link
Owner

Hello @danfelbm

Thank you for reporting the problem.

Do you think it would be better to simply prevent the admin to add a repeated course in a student's schedule?

@danfelbm
Copy link
Author

Hello,

Actually yes, that would be very useful; unfortunately it was not the first time that happened.
However we do have some classes that share a course (Critical Reading and Spanish are both in the same Course: Spanish) so it would be better to prevent repeated classes

Regards

@francoisjacquet
Copy link
Owner

Looking at the code itself, the SQL statements which check if the student is already enrolled in a class search the student's schedule for:

  • the course period
  • in combination with the start / end / enrollment dates.

See for example: https://github.com/francoisjacquet/rosariosis/blob/mobile/modules/Scheduling/MassSchedule.php#L72

So it seems we here have the possibility to add the same course twice, if and only if the student has already been dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants