Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use npm instead of Yarn? #34

Closed
christianbundy opened this issue Jan 2, 2020 · 3 comments
Closed

Should we use npm instead of Yarn? #34

christianbundy opened this issue Jan 2, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@christianbundy
Copy link
Member

What version of this package are you using? 2.9.10

What problem do you want to solve? I started using Yarn because the lockfile seemed a bit simpler and Yarn seemed to have better support for caching packages for offline reinstalls, but I'm worried that it was the wrong move. While investigating the best systemic solution for #29 I saw some issues (yarnpkg/yarn#2042 and yarnpkg/yarn#3266) that made me skeptical that Yarn is aligned with my values of beginner-friendly behavior.

What do you think is the correct solution to this problem? It's super important to me that Oasis is easy and accessible for beginners, and I'd imagine that most beginners are using npm. Should we switch to using npm and replace yarn.lock with package-lock.json?

Are you willing to submit a pull request to implement this change? Yes.

cc: @cinnamon-bun @trashhalo @jjehannet @mycognosist

@christianbundy christianbundy added the enhancement New feature or request label Jan 2, 2020
@christianbundy christianbundy self-assigned this Jan 2, 2020
@jedahan
Copy link
Collaborator

jedahan commented Jan 3, 2020

Huge fan of npm over yarn, for exactly the same reasons. I used to use yarn a bunch when it was significantly better, but was frustrated making new contributors jump through extra hoops.

@trashhalo
Copy link
Collaborator

Yarn was key when npm shrink wrap has terribad. These days there is very little light between the two solutions. I see no reason for oasis to stay on yarn.

@christianbundy
Copy link
Member Author

Sweet, thanks for all this input. Resolved in f26a148!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants