Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards compatibility issue #278

Open
vladiulianbogdan opened this issue Feb 16, 2019 · 3 comments
Open

Backwards compatibility issue #278

vladiulianbogdan opened this issue Feb 16, 2019 · 3 comments

Comments

@vladiulianbogdan
Copy link

vladiulianbogdan commented Feb 16, 2019 •
edited

Hi,

I've noticed that the NSLoggerData files generated before 10th December are not compatible anymore with newer versions of NSLogger. The logs will not appear in NSLogger if I try to open an .nslogger file.

In the commit with hash eef947f it seems like the LoggerConnection.m file was modified. In the initWithCoder method, the keys are different. That means file that were generated, for example, with key "message" and not compatible now with newer version because they are using key "_message".

Was this intended? If not, I have a fix this in a fork. Let me know if you want me to push a PR.

NSLogger is great! Thanks!
@fpillet
Copy link
Owner

fpillet commented Feb 16, 2019

I think this is a side effect of converting the viewer code from MRC to ARC! I didn't notice that we had backward compatibility issues, so yes please push your PR - thanks a lot!

@vladiulianbogdan
Copy link
Author

Here it is: #279.

@c0diq
Copy link
Contributor

c0diq commented May 29, 2019

Can we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fpillet @c0diq @vladiulianbogdan