Updated DSBF and added more convience to clean up the models. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal.asTimeSeries is already in fixed point as are the register values which can be accessed via 'mp.getReg(regName).value'. The audio data type is now accessible via mp.audio_dt
tvannoy
reviewed
Jan 29, 2021
tvannoy
reviewed
Jan 29, 2021
tvannoy
approved these changes
Jan 29, 2021
|
Implements and closes #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testSignal.asTimeSeries is already in fixed point as are the register values which can be accessed via 'mp.getReg(regName).value'. The audio data type is now accessible via mp.audio_dt.
I would take a look at the model to see how simplified it is now. No conversion blocks at the top level of the model and getting the register with its name will be much more convenient than needing to use its index. I have also dropped the use of
FromWorkspaceblocks and instead use constant because it is simpler and all thatmodel.jsonactually offers.