Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Yaml syntax highlighting #1400

Open
fox0430 opened this issue Jul 18, 2021 · 4 comments
Open

Enhance Yaml syntax highlighting #1400

fox0430 opened this issue Jul 18, 2021 · 4 comments

Comments

@fox0430
Copy link
Owner

fox0430 commented Jul 18, 2021

No description provided.

@kevinmatthes
Copy link
Contributor

@fox0430

As a first enhancement I would like to suggest to also apply the new comment logic introduced in #1533 -- as soon as it is merged.

In the long term, changes similar to #1533 for other language elements should be the next step. That way, the entire parsing logic could be decomposed into small, well-reusable and well-maintainable procedures such that adding new languages would require only their composition in just a few lines of code.

@kevinmatthes
Copy link
Contributor

@fox0430

The YAML highlighting outputs token types for which there is no colouring scheme, yet. Thus, the default colour will be applied. Configuring further colours for those token types should at least challenge the problem.

highlite defines 39 possible types, only for 13 of them are colours configured. This command will show which:

egrep 'gt.' src/moepkg/color.nim | grep Color | grep '  gt.' | cut -d'*' -f1 | cut -d' ' -f3

@kevinmatthes
Copy link
Contributor

@fox0430

I would like to add highlighting for the number types which are not coloured, yet. Is it okay if I would just map the decimal numbers' colour onto them, by default, unless there is a specific setting in the configuration file?

@fox0430
Copy link
Owner Author

fox0430 commented Dec 6, 2022

@kevinmatthes

I would like to add highlighting for the number types which are not coloured, yet. Is it okay if I would just map the decimal numbers' colour onto them, by default, unless there is a specific setting in the configuration file?

Ok. I think that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants