Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the changelog for 6.8.0 should mention the end of support for node-sass #12581

Open
stof opened this issue Aug 24, 2023 · 6 comments
Open

the changelog for 6.8.0 should mention the end of support for node-sass #12581

stof opened this issue Aug 24, 2023 · 6 comments

Comments

@stof
Copy link

stof commented Aug 24, 2023

3a4eecb introduces usages of @use in the Sass files, which is not supported by node-sass (because it is not implemented by libsass but only by dart-sass).

While this move is fine (dart-sass is the modern implementation of Sass), I think it would deserve being highlighted explicitly in the readme.

@alexeych
Copy link

Yep, and SASS versions support should be clearly stated in project description.
Foundation Sites 6.8.0 and Motion UI 2.0.4 don't support node-sass.

For example, "Zurb template" will fail to compile, because it requires the latest version of foundation-sites, but installs node-sass as well.

I tried to update foundation-sites and motion-ui in my boilerplate and didn't expect such breaking change in minor version.

@Currey
Copy link

Currey commented Sep 6, 2023

@alexeych have you found a work around? I still regularly use the foundation-zurb-template, but now can't work out how to get it to install without loads issues (which I'm guessing are due to node-sass?).

@stof
Copy link
Author

stof commented Sep 6, 2023

@Currey either use sass instead of node-sass or downgrade foundation-sites to 6.7. That's the workaround.

@erutan
Copy link

erutan commented Sep 19, 2023

foundation-zurb-template should really get an updated package.json. :)

I'm just keep it pinned < 6.8 for simplicity.

"foundation-sites": "~6.7.5",

@stof
Copy link
Author

stof commented Sep 19, 2023

@erutan updating the template is indeed a good move as tracked in #12588.

However, to resolve the current issue, I'm expected a maintainer to update the changelog for 6.8.0

@erutan
Copy link

erutan commented Sep 19, 2023

Yeah, that's why I made a different issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants