Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$enable-cite-block is missing !default from scss #12072

Closed
3 tasks done
alexkuc opened this issue May 7, 2020 · 3 comments · Fixed by #12073
Closed
3 tasks done

$enable-cite-block is missing !default from scss #12072

alexkuc opened this issue May 7, 2020 · 3 comments · Fixed by #12073

Comments

@alexkuc
Copy link
Contributor

alexkuc commented May 7, 2020

What should happen?

According to docs, it should be possible to disable styling of <cite>…</cite> tag using $enable-cite-block in _settings.scss.

What happens instead?

Foundation framework styles <cite>…</cite> tag regardless of the value of $enable-cite-block

Possible Solution

File scss/typography/_base.scss on the L200 is missing !default.

Test Case and/or Steps to Reproduce (for bugs)

How to reproduce:

  1. git clone https://github.com/alexkuc/foundation-sites-cite-block-bug
  2. yarn
  3. yarn build
  4. yarn start or use alternative hosting such as nginx or apache
  5. navigate to http://localhost:8888/ in order to open index.html which should be:

Screenshot 2020-05-07 20 55 56

but instead it is:

Screenshot 2020-05-07 20 56 11

Context

Not possible to disable formatting of <cite>…</cite> so I guess the context is typograhpy / custom css?

Your Environment

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • There are no other issues similar to this one.
  • The issue title and template are correctly filled.
@DanielRuf DanielRuf added the scss label May 7, 2020
@DanielRuf
Copy link
Contributor

Hi @alexkuc,

thanks for the hint. It seems it slipped through in c9fd9d7

And the same applies to $enable-code-inline.
Do you want to provide a PR which fixes this?

@alexkuc
Copy link
Contributor Author

alexkuc commented May 8, 2020

@DanielRuf I have created PR #12073. I hope I followed the format of the guidelines correctly (template and CONTRIBUTING.md). If I made a mistake, please let me know so I can fix it. Thank you!

@DanielRuf
Copy link
Contributor

@alexkuc thank you for your contribution. I will check this when I find some time.

DanielRuf added a commit that referenced this issue Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants