Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"dropdown menu" in "top-bar" suffers background override #10621

Closed
udf2457 opened this issue Sep 6, 2017 · 3 comments
Closed

"dropdown menu" in "top-bar" suffers background override #10621

udf2457 opened this issue Sep 6, 2017 · 3 comments

Comments

@udf2457
Copy link

udf2457 commented Sep 6, 2017

Hi,

This sort of thing will leave dropdown menu inheriting top-bar background colour, which is undesireable as it renders the menu content illegible.

<div class="top-bar" id="example-menu">
  <div class="top-bar-left">
    <ul class="dropdown menu" data-dropdown-menu>
      <li class="menu-text">Site Title</li>
      <li>
        <a href="#">One</a>
        <ul class="menu vertical">
          <li><a href="#">One</a></li>
          <li><a href="#">Two</a></li>
          <li><a href="#">Three</a></li>
        </ul>
      </li>
      <li><a href="#">Two</a></li>
      <li><a href="#">Three</a></li>
    </ul>
  </div>
  <div class="top-bar-right">
    <ul class="menu">
      <li><input type="search" placeholder="Search"></li>
      <li><button type="button" class="button">Search</button></li>
    </ul>
  </div>
</div>
@kball
Copy link
Contributor

kball commented Sep 12, 2017

I believe this was deliberate, but I don't remember the reasoning and it definitely seems less than optimal.
cc @IamManchanda @rafibomb @brettsmason do you have thoughts & recommendations on the best way to handle this?

@IamManchanda
Copy link
Contributor

IamManchanda commented Sep 12, 2017

This is like this:
https://github.com/zurb/foundation-sites/blob/develop/scss/components/_top-bar.scss#L47-L57

Here are the variables:
https://github.com/zurb/foundation-sites/blob/develop/scss/components/_top-bar.scss#L13-L19

I think we need to add more variables and logic in there? Thoughts ?

@IamManchanda
Copy link
Contributor

IamManchanda commented Sep 12, 2017

Also (outside the topic)
#10056 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants