Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple !global assignments deprecation warnings on foundation-rails-6.6.2.0 #296

Open
cesarizu opened this issue Jun 9, 2020 · 4 comments

Comments

@cesarizu
Copy link

cesarizu commented Jun 9, 2020

When using foundation-rails-6.6.2.0 (and other older versions too), I get a lot of deprecation warnings on the console:

DEPRECATION WARNING on line 115 of /home/travis/build/company/project/vendor/bundle/ruby/2.6.0/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_color.scss:

!global assignments won't be able to declare new variables in future versions.

Consider adding `$primary-color: null` at the top level.

These are all the relevant lines from the logs:

Consider adding `$alert-color: null` at the top level.
Consider adding `$primary-color: null` at the top level.
Consider adding `$secondary-color: null` at the top level.
Consider adding `$success-color: null` at the top level.
Consider adding `$warning-color: null` at the top level.
Consider adding `$-zf-bp-value: null` at the top level.
Consider adding `$-zf-size: null` at the top level.
@xxx
Copy link

xxx commented Jun 18, 2020

We also started seeing these after updating to sassc v.2.4.0.

@nbw
Copy link

nbw commented Jun 24, 2020

PR: #298

@OdairTrujillo
Copy link

Just put $primary-color: null; at the top of the file. It will declare the $primary-color variable before being used by the global assignment.

@asecondwill
Copy link

Just put $primary-color: null;

but for loads of variables? isnt this something that should be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants