Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue focus outline on modals and slow click to dismiss #213

Open
chrismanderson opened this issue Dec 15, 2016 · 0 comments
Open

Blue focus outline on modals and slow click to dismiss #213

chrismanderson opened this issue Dec 15, 2016 · 0 comments

Comments

@chrismanderson
Copy link

chrismanderson commented Dec 15, 2016

When using version 6.2.4.0 of this gem, I see the blue focus outline around modals. However, I do not see this outline when doing a fresh install of foundation via the NPM installer, leading me to believe there is something amiss with the rails version. Not only that, there's clearly a delay present in dismissing modals with the outline than without; the browser takes a moment to clear the outline, then clears the modal.

How can we reproduce this bug?

  1. Step one
    Install 6.2.4.0 of this gem into a Rails app.

  2. Step two
    Open a modal.

     <div class="tiny reveal" id="exampleModal" data-reveal>
         <!-- ... -->  
     </div>
    
     <a data-open="exampleModal" aria-controls="exampleModal" aria-haspopup="true" tabindex="0">Click me for a tiny modal</a>```
    
    
  3. Dismiss the model

What did you expect to happen?
There should not be a blue outline around the modal. The modal should not delay when closing.

What happened instead?
There was a blue outline around the modal and it delayed when closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant