Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(ui): /myRecentJobs page completed #228

Closed
wants to merge 3 commits into from
Closed

feature(ui): /myRecentJobs page completed #228

wants to merge 3 commits into from

Conversation

soham4abc
Copy link
Contributor

Description

/allRecentJobs page UI is completed with a table featuring dynamic search and pagination. Also with a customizable number of rows.

Changes

A new package has been installed MDBreact (https://github.com/mdbootstrap/mdb-react-ui-kit)
(same in PR #223 )

How to test

install the updated dependencies and run the server to visit the /myRecentJobs page

Screenshots

User 1 perspective:
Screenshot from 2022-06-17 19-27-39

User 2 perspective:
Screenshot from 2022-06-17 19-28-09

Fixes #226

@shaheemazmalmmd @GMishx @sjha2048 PTAL

GMishx
GMishx requested changes Jun 21, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with the changes, I am getting following error while compiling.
Is it some issue from my end?

Failed to compile.

src/pages/Jobs/MyRecentJobs/index.jsx
  Line 31:30:  Unable to resolve path to module 'mdbreact'  import/no-unresolved

Search for the keywords to learn more about each error.

src/pages/Jobs/MyRecentJobs/index.jsx Outdated Show resolved Hide resolved
src/pages/Jobs/MyRecentJobs/index.jsx Outdated Show resolved Hide resolved
@GMishx
Copy link
Member

GMishx commented Jun 21, 2022

Also, the commit message is in wrong format. It should be
feat(ui): my recent jobs page completed

@soham4abc
Copy link
Contributor Author

Along with the changes, I am getting following error while compiling. Is it some issue from my end?

Failed to compile.

src/pages/Jobs/MyRecentJobs/index.jsx
  Line 31:30:  Unable to resolve path to module 'mdbreact'  import/no-unresolved

Search for the keywords to learn more about each error.

Did you run yarn install? A new package is used in this PR. If not please do so and restart the server. If that too doesn't work.. try deleting old node_modules and run yarn install to get fresh list of packages.

Thank you, do let me know if the problem persists.

@GMishx
Copy link
Member

GMishx commented Jun 21, 2022

I did the exact same steps but it failed last time.

I did the exact same steps again and it worked this time. :-P

@GMishx
Copy link
Member

GMishx commented Jun 21, 2022

Looks like theming issue
image

image

@soham4abc
Copy link
Contributor Author

Looks like theming issue image

image

Yes this is a theming issue

@soham4abc
Copy link
Contributor Author

Fixing it

@soham4abc
Copy link
Contributor Author

Fixed @GMishx

Screenshot from 2022-06-21 14-48-01

@soham4abc soham4abc requested a review from GMishx June 21, 2022 09:24
@GMishx GMishx added needs review Need code review needs test Needs testing labels Jun 23, 2022
@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Jun 23, 2022
@github-actions
Copy link

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR has merge conflicts, require rebase label Jun 24, 2022
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Jul 5, 2022
@soham4abc
Copy link
Contributor Author

soham4abc commented Jul 14, 2022 •
edited

Closing this, PR this needs a fresh implementation after discussion.

@GMishx

@soham4abc soham4abc closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx Awaiting requested review from GMishx

Assignees
No one assigned
Labels
has merge conflicts PR has merge conflicts, require rebase needs review Need code review needs test Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creation of my recent jobs page
2 participants
@soham4abc @GMishx