Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured speakers and speakers should show up when session is accepted #2088

Open
mariobehling opened this issue Sep 1, 2018 · 2 comments · May be fixed by #2670
Open

Featured speakers and speakers should show up when session is accepted #2088

mariobehling opened this issue Sep 1, 2018 · 2 comments · May be fixed by #2670
Assignees
Labels
Milestone

Comments

@mariobehling
Copy link
Member

Featured speakers and the speakers page don't show speakers even though their session has been accepted (however not scheduled yet). They only show up when they are scheduled.

@dhruvjain99
Copy link
Contributor

dhruvjain99 commented Oct 29, 2020

Seems like this issue is resolved by looking into the codebase as this case is handled here in fold_v2.js file.

speakerid.forEach((speaker) => {
   if (speaker !== undefined) {
     speakerSessionDetail = sessionsMap.get(speaker.id);
     if (speakerSessionDetail === undefined) {
       return;
     }
     if (speakerSessionDetail.state === 'accepted' || speakerSessionDetail.state === 'confirmed') {
       sessiondetail.push({
         detail: speakerSessionDetail
       });
     }
   }
});

There is already a check to handle such a case.
According to the above code, the speaker who has a session state as accepted is part of the speakerslist on the speakers page and featured section(if the speaker is featured) but it won't render/show speakers who are a part of speakers json and doesn't have any session. So according to me, this issue is already resolved.
@mariobehling @iamareebjamal do let me know if I am missing anything and the issue is yet to be solved.

@dhruvjain99
Copy link
Contributor

If you want to display all the speakers irrespective of whether that speaker has a session or not, I'll do it but do let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants