Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the letters q and Q. #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support the letters q and Q. #145

wants to merge 1 commit into from
+20 −1

Conversation

kohei-noda-qcrg
Copy link

@kohei-noda-qcrg kohei-noda-qcrg commented Feb 13, 2023 •
edited

It is the implementation and its testing to resolve #144

Supports quadruple_precision expressions such as
r = 1.0Q-10

@kohei-noda-qcrg
Copy link
Author

@gnikit
@awvwgk
Could you review if this feature is needed and its implementation?

@kohei-noda-qcrg
Copy link
Author

@awvwgk
Some CIs failed, but the reason is due to the version of the ubuntu OS used in the test.

OS version

https://github.com/pseewald/fprettify/actions/runs/4161587117/jobs/7669164318#step:1:4
ubuntu-latest means ubuntu-22.04 LTS

Requirements for the failed test

https://github.com/pseewald/fprettify/blob/f5061b53459e1910c39a2b295c937624763ab15e/.github/workflows/test.yml#L88
pip workflows requires python 3.5 and 3.6.

Reasons for failure

actions/setup-python#544
However, according to this issue, ubuntu-22.04 LTS no longer supports python version ≤ 3.6.

Solution

I think there are two options to solve this problem

  1. Temporary use ubuntu-20.04 image for CI.
  2. use python version ≥ 3.7 for CI.

How should we solve this problem?

@gnikit
Copy link
Member

gnikit commented Mar 14, 2023

We have some PRs in the pipeline updating the CI.

@kohei-noda-qcrg
Copy link
Author

kohei-noda-qcrg commented Mar 14, 2023 •
edited

@gnikit
I see. I checked #135 is the pipeline upgrade pull request.

gnikit
gnikit requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase to the latest master?

@kohei-noda-qcrg
Copy link
Author

Sure. I will rebase this pr to the latest master branch.

@kohei-noda-qcrg
Support the letters q and Q.
e6718da 
quadruple_precision expressions
@kohei-noda-qcrg
Copy link
Author

@gnikit
I rebased this pull request to the latest master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnikit gnikit gnikit requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Support the letters q and Q in the expression of quadruple precision variables.
2 participants
@kohei-noda-qcrg @gnikit