Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for collaborator(s) to maintain fprettify #127

Open
pseewald opened this issue Aug 22, 2022 · 12 comments
Open

Looking for collaborator(s) to maintain fprettify #127

pseewald opened this issue Aug 22, 2022 · 12 comments

Comments

@pseewald
Copy link
Collaborator

I'm looking for collaborators who'd like to help me maintain this repository. Since I'm no longer an active Fortran developer, I'd like to slowly handover this project. If you're interested, please contact me via E-Mail, or respond to this issue.

@gnikit
Copy link
Member

gnikit commented Aug 22, 2022

Hi @pseewald, I am more than happy to help out with some of the maintenance and dev work. freptiffy ships with the Modern Fortran extension so it is definitely in our best interest to keep the project alive. I also suspect that a few more members of Fortran-lang would be interested in helping out.

@pseewald
Copy link
Collaborator Author

@gnikit thanks a lot for reaching out. I have to say, I'm really impressed by the Fortran-lang community and its projects, and for sure I'd appreciate a collaboration. In the short term, I can give you (and other members of Fortran-lang) collaborative access to the fprettify repository. In the long run, we can also consider transferring ownership to Fortran-lang, if the Fortran-lang community would be willing to take over. But before that, I suggest that we first try to bring this repository into good shape again (review, test and merge open pull request and make a priority list of issues to be fixed). I'll help with that, I won't abandon this project right now.

@awvwgk
Copy link
Member

awvwgk commented Aug 23, 2022

I'd be happy to help out as well. I have been packaging fprettify for conda-forge, MSYS2 and homebrew to make it easier to use in various environments, specially when using it in teaching.

@gnikit
Copy link
Member

gnikit commented Aug 23, 2022

In the short term, I can give you (and other members of Fortran-lang) collaborative access to the fprettify repository. ... suggest that we first try to bring this repository into good shape again (review, test and merge open pull request and make a priority list of issues to be fixed).

Yeah, that sounds good to me.

I suppose the long term solution would be optimal, since it would allow more people other than the repo owner to upload secrets to the GitHub repo (collaborators do not have these access rights).

We can start a Project to track issues and PRs that need to be dealt with.

@awvwgk
Copy link
Member

awvwgk commented Aug 23, 2022

I'm really impressed by the Fortran-lang community and its projects, and for sure I'd appreciate a collaboration. In the short term, I can give you (and other members of Fortran-lang) collaborative access to the fprettify repository. In the long run, we can also consider transferring ownership to Fortran-lang, if the Fortran-lang community would be willing to take over.

This would indeed be a possibility, I just invited you to @fortran-lang. We have been including a range of projects under this namespace to enhance their visibility and provide the possibility for community maintenance. Of course, being under @fortran-lang doesn't magically increase the numbers of active contributors.

@pseewald
Copy link
Collaborator Author

What CI service do you typically use @fortran-lang? I relied on Travis CI in the past, but this is no longer available for free. If we plan to move this to @fortran-lang, I think it makes sense to choose a CI service that is already established in your community. Related: #128

@awvwgk
Copy link
Member

awvwgk commented Aug 30, 2022

We are using GH actions at the moment.

@gnikit
Copy link
Member

gnikit commented Aug 30, 2022

We use GitHub Actions as @awvwgk mentioned. We can more or less copy paste the ones I use in fortls. They cover:

  • CI
  • Coverage
  • Documentation website building
  • PyPi publishing
  • Code Quality (for security vulnerabilities)
  • Dependabot for GitHub Actions itself

@wpbonelli
Copy link

wpbonelli commented Mar 9, 2024

I'd be happy to help, particularly testing and bugfixes. I'd like to submit patches for #169 and #170 with tests. Happy to work on converting to pytest as proposed in #136 as an initial step.

Also have some reformatting rules in another project that could move here if people like them, e.g.

  • putting variable and procedure declarations on separate lines
  • removing unneeded trailing return statements*
  • removing empty comments

*This sort of thing would need refactoring to look above/below the current line. Maybe beyond the scope of fprettify? But if there is interest, I'd feel more comfortable doing it after updating the test framework.

@pseewald
Copy link
Collaborator Author

pseewald commented Apr 2, 2024

@wpbonelli Thanks a lot for your work. Unfortunately, pr's have been open for a while in this repo because I haven't found any time to spend on this project. But things have improved lately and I'll have a look later this month to make sure that I can review open pr's (and, hopefully, get them merged).

Also, I have started revamping tests which should simplify the setup. Now that you're also interested in working on tests, I'll make sure that I can commit my changes until the end of this month. I'd suggest that you wait with any larger changes on the test framework (such as converting to pytest) until then (but, indeed, moving to pytest would be a very welcome change).

Also have some reformatting rules in another project that could move here if people like them, e.g.

putting variable and procedure declarations on separate lines
removing unneeded trailing return statements*
removing empty comments
*This sort of thing would need refactoring to look above/below the current line. Maybe beyond the scope of fprettify? But if there is interest, I'd feel more comfortable doing it after updating the test framework.

Optional features are always welcome as long as they don't change the default behavior, and as long as they are properly integrated into fprettify.

@pseewald
Copy link
Collaborator Author

pseewald commented Apr 2, 2024

@gnikit @awvwgk would you still be interested in helping me moving this repo to @fortran-lang? If so, please let me know what steps I need to do to. I have been doing a bad job in maintaining this repo, and I'd be happy to hand it over.

@gnikit
Copy link
Member

gnikit commented Apr 2, 2024

Yeah that would be great. It should be relatively easy to move the repo. The PyPi stuff is slightly more tricky, but it's nothing we haven't done before (see fortls and fpm PyPi packages).

I will send you an email with Sebastian (@awvwgk ) tomorrow. Does that sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants