Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export WithId in the Rust compiler and use it in rust-sgx #533

Open
vn971 opened this issue Oct 12, 2023 · 0 comments
Open

Export WithId in the Rust compiler and use it in rust-sgx #533

vn971 opened this issue Oct 12, 2023 · 0 comments

Comments

@vn971
Copy link

vn971 commented Oct 12, 2023

Currently, our codebase uses transmute to handle "internal" and "external" definitions of WithId in Rust standard library (the SGX platform of it) and in rust-sgx (this repository). While technically currently "safe", we're lacking compiler-enforced checks on this type. It is arguably safer to rather export WithId and re-use it, thus avoiding the need for std::mem::transmute.

This was originally raised here: #515 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant