Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

Missing dist directory #56

Open
cbfx opened this issue Sep 26, 2015 · 4 comments
Open

Missing dist directory #56

cbfx opened this issue Sep 26, 2015 · 4 comments

Comments

@cbfx
Copy link
Contributor

cbfx commented Sep 26, 2015

I'm sorry I cannot provide a jsbin example because I am unaware of how to reproduce webpack issues. Basically, your dist directory is not available as an npm package and trying to include this library via require('angular-formly-templates-bootstrap') fails for me.

Here's the comment I posted at the commit:
3e83fe5#commitcomment-13453757

I would normally send a pull request with this because it's very clearly resolvable with an .npmignore file but I do not know what kinds of practices you believe in. I'm going to pin my package to 6.1.0.

Cheers.

Update: Just for good measure, I added this pull request. #57

Thanks for reading.

@kentcdodds
Copy link
Member

Did it get fixed?

@cbfx
Copy link
Contributor Author

cbfx commented Sep 27, 2015

@kentcdodds not sure. i am out atm but it should. i'll give you an update soon.

@josetaira
Copy link

Hello @kentcdodds, dist is missing again in 6.3.1. It was available back in 6.2.0. Is this expected?

@kentcdodds
Copy link
Member

This should be fixed in the latest version. Sorry about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants