Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature component render fails on CRA apps #211

Closed
josefernand opened this issue Oct 10, 2017 · 1 comment
Closed

Signature component render fails on CRA apps #211

josefernand opened this issue Oct 10, 2017 · 1 comment

Comments

@josefernand
Copy link

Yesterday I found a problem in the signature component on a create-react-app application. The component does not render and stops the form rendering process so the form is shown broken.
Doing some research, I found this signature_pad issue related to the new webpack2 export/import process: szimek/signature_pad#257
The problem seems to be fixed pointing the signature_pad import to the .js file in the src/components/signature/Signature.js component.

import SignaturePad from 'signature_pad/dist/signature_pad.js';

I have this tested on my fork and it works. Let me know and I will send the PR if you want.

@travist
Copy link
Member

travist commented Oct 11, 2017

Fixed in 2.19.3 release. Thanks!

@travist travist closed this as completed Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants