Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update helm chart and add some feature #33

Open
bvis opened this issue Oct 13, 2020 · 7 comments
Open

[Feature] Update helm chart and add some feature #33

bvis opened this issue Oct 13, 2020 · 7 comments

Comments

@bvis
Copy link

bvis commented Oct 13, 2020

Hi, it seems that the helm chart is a bit old and I'm missing some features, like the simple usage of push-gateway.

That's why I've created this repo: https://github.com/softonic/pagespeed-exporter-chart

If you find this useful I could update the provided chart here to maintain just 1 version or switch the reference in the project to my version.

By now the helm chart is available to use in a public helm hub: https://artifacthub.io/packages/helm/softonic/pagespeed-exporter

@Romiko
Copy link
Contributor

Romiko commented Oct 15, 2020

Hey, I like your helm chart and I am testing it out now.

Do you have the same issue where scraping the pod directly can take over 30 seconds? So it is impractical for prometheus to scrape directly. The way around it, is only scrape via the gateway?

@Romiko
Copy link
Contributor

Romiko commented Oct 15, 2020

I created a PR with your work and some minor fixes to get your chart working correctly.

#35

@bvis
Copy link
Author

bvis commented Oct 15, 2020

I've tested it just via the gateway, but you could get it working if you define a higher timeout value in the scraping config in Prometheus, I guess.

On other hand it's common to use Prometheus Operator, it provides the ServiceMonitor resource where you can define more configuration values like the timeout value and other service discovery values. If you need some help I could try to adapt my helm chart and test it.

@Romiko
Copy link
Contributor

Romiko commented Oct 16, 2020

Yeah, I have it working nicely. The secret is removing the proves and HPA. I will create a new PR now for this 👍

@Romiko
Copy link
Contributor

Romiko commented Oct 16, 2020

When I get a chance, I will optimize the image so http requests are immediate and it uses the previous run cycle as the results.

@bvis
Copy link
Author

bvis commented Oct 16, 2020

Hi, I forgot to mention you that yesterday I did the change to add the serviceMonitor, you can see it in the 1.1.0 version of the chart: https://artifacthub.io/packages/helm/softonic/pagespeed-exporter

@smartinov
Copy link
Contributor

So, is this still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants