Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to write the PR comments in a compact manner using a markdown table #123

Open
SeeringPhil opened this issue Sep 6, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@SeeringPhil
Copy link

Is your feature request related to a problem? Please describe.
When running on multiple urls (in my case, a baseUrl with subPaths), the format is not as expected when displaying performance.
See issue #122

I think adding a way to display the results in a more compact manner, like the solution described below, would both provide a nice solution to my personal problem while adding a valuable new feature to everyone using the action.

Right now, the way the results are displayed quickly becomes noisy and clutters the PR, while having this possibility would improve the readability.

Describe the solution you'd like
Provide a mechanism to have a compact comment mode which would output something like this:

Device URL Accessibility Best practices Performance PWA SEO
mobile baseUrl 95 90 95 80 100
desktop baseUrl 90 90 95 80 100
mobile baseUrl/subPath1 92 90 95 80 100
desktop baseUrl/subPath1 92 90 95 80 100

Additional context
N/A

@SeeringPhil SeeringPhil changed the title Add a 'prCommentCompact' Add a way to write the PR comments in a compact manner using a markdown table Sep 6, 2023
@SeeringPhil
Copy link
Author

A suggestion for the possible input parameter could be :
'prCommentCompact'
or maybe
'prCommentTable'

@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@SeeringPhil
Copy link
Author

@adamhenson Thanks for the feedback!

Knowing you accept PRs I'll take a look at implementing the changes I mentioned in those 2 issues when I'll get around to implement lighthouse checks in our projects.

@adamhenson
Copy link
Collaborator

adamhenson commented May 3, 2024

Thanks @SeeringPhil - and FWIW this GitHub Action is pretty much a pass-through to @foo-software/lighthouse-check (which I also maintain), which is where the change would really need to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants