Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting (non-neo)-vim #256

Open
riley-martine opened this issue Oct 30, 2022 · 8 comments
Open

Targeting (non-neo)-vim #256

riley-martine opened this issue Oct 30, 2022 · 8 comments

Comments

@riley-martine
Copy link
Contributor

I love the tokyonight-day colorscheme, but I use standard vim, so I can't use this plugin. My current solution is hacked terribly on top of tokyonight-vim. I'm going to make something a bit nicer, and was wondering if adding a target for vim here would be a feasible solution, or out of scope for this project. This project sees more active development I was hoping to piggyback off of, and uses different colors which I like better. If this is work you'd like to be included, I can work on a PR.

Tips would be appreciated, if there is an approach you see that would be better to start with. (I was planning on just generating a single .vim file for each colorscheme, but maybe there's a way to make a whole plugin?)

@max397574
Copy link

the problem is that at the moment everything is done in lua
everything would have to be redone in vimscript for it to work in vim
in my opinion this should be a separate plugin

@folke
Copy link
Owner

folke commented Oct 31, 2022

It can be done with the extras templates though, but skipping any customizations

@riley-martine
Copy link
Contributor Author

riley-martine commented Dec 31, 2022

Working on this over here: https://github.com/riley-martine/tokyonight.nvim/tree/gen-vim

Right now it sort of works. A few bugs to figure out, and a few places that it wants to be extended. Also kind of a mess because I don't know lua yet.

@riley-martine
Copy link
Contributor Author

It works! And an airline theme! The code is not good though. I need to fix that. It also doesn't highlight markdown as well as the old tokyonight.vim.

Screenshot 2023-04-07 at 8 53 55 PM

@folke
Copy link
Owner

folke commented Apr 16, 2023

@riley-martine looks great!

@ccrenfroe
Copy link

@riley-martine Curious if you may still have plans to work on this? I took a little peek at your fork and seems its been a few months since you were working on it, but were able to find some success?

@riley-martine
Copy link
Contributor Author

@ccrenfroe it works right now, and I use my fork on my personal machine; here is the vim-plug config to use it:

Plug 'riley-martine/tokyonight.nvim',
    \ { 'branch': 'gen-vim',
    \   'as': 'tokyonight',
    \   'do': 'mkdir -p autoload/airline/themes; '
    \    . 'mv -f extras/vim_airline/*.vim autoload/airline/themes/; '
    \    . 'mv -f extras/vim/*.vim colors/'}

unfortunately the chosen colors are worse than what I've been using on my work machine: https://github.com/riley-martine/vim-theme-work. (This is a hacked-up version of the original https://github.com/ghifarit53/tokyonight-vim. I've made it public just now so you can see if you want. It wasn't meant to be, though, so it's a bit rough.)

to get this to a "completed" state:

  • the generated tokyonight.nvim colors should be adjusted to be closer to the vim-theme-work ones
  • if past-me is to be believed, the code in this PR requires a pass or two to clean it up

I have unfortunately lost most of the élan vital required to teach the computer new things. It may return at some point, it may not. If @folke likes what's already here, the code could be merged and the color twiddling left up to future contributors. If not, either someone else can pick this up or we can wait to see if I ever get around to it. Sorry about that!

@AndrewRadev
Copy link

This new project might give you a solution: https://github.com/skywind3000/vim-color-export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants