Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not dim night theme #211

Open
balazser opened this issue Sep 13, 2022 · 1 comment
Open

Does not dim night theme #211

balazser opened this issue Sep 13, 2022 · 1 comment

Comments

@balazser
Copy link

Thank you for the awesome theme!

The config

dim_inactive = false, -- dims inactive windows

works well for the storm theme but not for the night theme. This is probably because we set the bg_dark for the dim.

NormalNC = { fg = c.fg, bg = options.transparent and c.none or options.dim_inactive and c.bg_dark or c.bg }, -- normal text in non-current windows

Should the dim feature make the text darker than the background? 🤔

@JohnnyGOX17
Copy link

I ran into this as well, but I was able to get around it by re-mapping the background color schemes for night theme:

require("tokyonight").setup({
  style = "night",
  dim_inactive = true,

  on_colors = function(colors)
    colors.bg = "#181818"
    colors.bg_dark = "#101010"
  end
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants