Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: field type has changed in lua_ls config #47

Open
1 task done
pysan3 opened this issue Nov 8, 2023 · 1 comment
Open
1 task done

feature: field type has changed in lua_ls config #47

pysan3 opened this issue Nov 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@pysan3
Copy link

pysan3 commented Nov 8, 2023

Did you check the docs?

  • I have read all the neoconf.nvim docs

Is your feature request related to a problem? Please describe.

With a recent change in lua_ls (PRs listed below), the expected values for workspace.checkThirdParty has changed from a boolean to string enum.

Please update the schema to align with the latest changes.
Please see # Describe the solution you'd like section for the explanation of the new values.


Sidenote:

Not related to the new schema but there seems to still be an issue with type conversion atm to keep backwards compatibility working.

Describe the solution you'd like

Change schema for lua_ls.


This lets you skip the "apply third party library to workspace configuration" prompt.

The value of Lua.workspace.checkThirdParty can now be one of:

Ask (ask every time; this is equivalent to true)
Apply (always apply third-party libraries and set the workspace
configuration)
ApplyInMemory (always apply third-party libraries but don't set the
workspace configuration)
Disable (don't ask and don't apply; this is equivalent to false)

Backwards compatibility with the old boolean configuration values is maintained; true is treated as Ask and false is treated as Disable.

Describe alternatives you've considered

None.

Additional context

No response

@pysan3 pysan3 added the enhancement New feature or request label Nov 8, 2023
@pysan3
Copy link
Author

pysan3 commented Nov 9, 2023

Thanks to this PR, it is now not a breaking change but the values have been extended. LuaLS/lua-language-server#2409

The values this option can take is as follows.

  • bool: true, false
  • string:
    • Ask (same as true)
    • Apply
    • ApplyInMemory
    • Disable (same as false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant