Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compressing twice is counter-productive #10

Open
PerBothner opened this issue Jul 5, 2021 · 0 comments
Open

compressing twice is counter-productive #10

PerBothner opened this issue Jul 5, 2021 · 0 comments

Comments

@PerBothner
Copy link

In builder.js the compression method deflateRaw is called twice. The general "received wisdom" is that trying to compress an already-compressed while is unlikely to lead to further compression and may in fact lead to worse compression.

Out of curiosity, I modified builder.js when using it to generate the classes-v13.0.0.mjs (for graphene-breaker-mjs). The data buffer was 39184 bytes. After the first deflateRaw the result was 2176 bytes. After the second, the result was 2181 bytes. Oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant