New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not returning required flag for trailing CR LF #27

Open

toptensoftware opened this issue May 10, 2020 · 0 comments

toptensoftware commented May 10, 2020

If a string ends with '\r\n' the final returned line break position doesn't have the 'required' flag set.

This line should include a check and return appropriately:

linebreak/src/linebreaker.js

Line 194 in 9096a22

return new Break(this.string.length);

eg: perhaps this:

var required = (this.curClass === BK) || ((this.curClass === CR) && (this.nextClass !== LF));
return new Break(this.string.length, required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment