Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing residues #3

Open
nezix opened this issue Jul 18, 2018 · 2 comments
Open

Missing residues #3

nezix opened this issue Jul 18, 2018 · 2 comments

Comments

@nezix
Copy link

nezix commented Jul 18, 2018

Some residues at the beginning and at the end of the chains are missing in the mesh.

If you compare a cartoon mesh from pymol/VMD/avogadro... and the mesh created by ribbon.go, you can see that some parts are missing.

For example :

Beginning of the chain:
image

End of the chain
image

@fogleman
Copy link
Owner

Good catch!

I pulled up the code and look what I found: https://github.com/fogleman/ribbon/blob/master/ribbon/ribbon.go#L286

I can look into it.

What are you doing with the code? I'm excited to see someone else using it!

@nezix
Copy link
Author

nezix commented Jul 18, 2018

:D
I am working on UnityMol (https://twitter.com/n3zix & https://twitter.com/unitymol).
At the beggining I was looking for some open source code that I could use in that project to create cartoon meshes. It turns out there are a lot of open code in javascript but usually messy / hard to understand & maintain.
Your cartoons are polished and the code is understandable so I am translating your code to C# to integrate it in Unity if you are ok with it.
Next step might be to speed things up to compute meshes efficiently.

Thank you for taking a look !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants