Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP listener stuck while processing TLS handshake #1767

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

TCP listener stuck while processing TLS handshake #1767

wants to merge 6 commits into from

Conversation

amoerie
Copy link
Collaborator

@amoerie amoerie commented Mar 22, 2024

Fixes #1766

Checklist

  • The pull request branch is in sync with latest commit on the fo-dicom/development branch
  • I have updated API documentation
  • I have included unit tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file

Changes proposed in this pull request:

  • Move DesktopNetworkStream ctor to Task.Run, out of the main TCP listener loop
  • Add test that demonstrates issue

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.42%. Comparing base (b45ffe1) to head (487f62c).
Report is 21 commits behind head on development.

Files Patch % Lines
FO-DICOM.Core/Network/DesktopNetworkManager.cs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           development    #1767   +/-   ##
============================================
  Coverage        76.42%   76.42%           
============================================
  Files              275      275           
  Lines            25410    25423   +13     
  Branches          3043     3046    +3     
============================================
+ Hits             19419    19430   +11     
- Misses            5062     5064    +2     
  Partials           929      929

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amoerie amoerie mentioned this pull request Mar 29, 2024
Open
@amoerie amoerie marked this pull request as ready for review May 2, 2024 06:46
@amoerie amoerie marked this pull request as draft May 2, 2024 06:47
@amoerie amoerie marked this pull request as ready for review May 2, 2024 06:58
@amoerie amoerie requested a review from gofal May 2, 2024 06:58
@amoerie amoerie mentioned this pull request May 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gofal gofal Awaiting requested review from gofal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCP listener stuck while processing TLS handshake
1 participant
@amoerie