Apply fallbackencoding of DicomServices to the DicomDatasets that are sent through this DicomService #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DicomDatasets of the messages sent through this DicomService
…t the fallbackencoding is applied to the messages only if explicitly set by a user
amoerie
reviewed
May 23, 2024
| @@ -24,7 +24,7 @@ public partial class DicomDataset : IEnumerable<DicomItem>, IEquatable<DicomData | |||
| private readonly IDictionary<DicomTag, DicomItem> _items; | |||
|
|
|||
| private DicomTransferSyntax _syntax; | |||
| private Encoding[] _fallbackEncodings = DicomEncoding.DefaultArray; | |||
| internal Encoding[] _fallbackEncodings = DicomEncoding.DefaultArray; | |||
There was a problem hiding this comment.
Instead of making this internal, wouldn't it make more sense to move the Clone method back to DicomDataset? If you look at how records are implemented in C#, they are also responsible for their own cloning, this is not implemented externally.
|
One minor consideration related to cloning, but other than that a nice improvement! 👍 |
mrbean-bremen
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1642 .
Checklist
Changes proposed in this pull request: