Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the wording of the repair message. #3853

Open
bsutton opened this issue Mar 7, 2024 · 0 comments
Open

Change the wording of the repair message. #3853

bsutton opened this issue Mar 7, 2024 · 0 comments

Comments

@bsutton
Copy link

bsutton commented Mar 7, 2024

Which version and edition of Flyway are you using?

10.8.1

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

maven

Which database are you using? (Type & version)

mariadb 10

Which operating system are you using?

Linux

What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)

When starting my web app flyway outputs the following message:

Repair of failed migration in Schema History table `op`.`flyway_schema_history` not necessary. No failed migration detected.
Successfully repaired schema history table `op`.`flyway_schema_history` (execution time 00:00.050s).

This message is a distraction as I read the first section 'Repair of failed migration in' and immediately think that something
went wrong - requiring me to read the whole message.

I'm guessing the second line is just wrong and that no repair actually occurred.

A rewording of the message would remove the distraction.

My suggestion would be:

Flyway: healthy schema history table op`.`flyway_schema_history` scanned.

In case of a failure in the history table:

Flyway: detected  failed migration in Schema History table `op`.`flyway_schema_history`.
Flyway: Successfully repaired schema history table `op`.`flyway_schema_history` (execution time 00:00.050s).

The second sentence still doesn't quite make sense - does flyway actually repair the history table?
So pick your own version of the sentences, just remove the alarm caused by the opening sentence of 'Repair of failed...'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant